Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Swift pod lottie-react-native depends upon DoubleConversion, which does not define modules. #1223

Closed
aliza-khu opened this issue Apr 23, 2024 · 6 comments

Comments

@aliza-khu
Copy link

Description

[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod lottie-react-native depends upon DoubleConversion, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set use_modular_headers! globally in your Podfile, or specify :modular_headers => true for particular dependencies.

Steps to reproduce

Under iOS Directory hit pod install command.

Snack or a link to a repository

none

Lottie React Native version

6.7.2

React Native version

0.74.0

Platforms

iOS

Workflow

React Native

Architecture

Paper (Old Architecture)

Build type

None

Device

None

Acknowledgements

Yes

@a289459798
Copy link

same

@ethanneff
Copy link
Contributor

ethanneff commented Apr 24, 2024

i tried adding pod 'DoubleConversion', :modular_headers => true without success.

started happening when upgrading from RN 0.73.6 to 0.74.0

@ethanneff
Copy link
Contributor

downgrading to RN 0.73.7 is a short-term solution

@aliza-khu
Copy link
Author

aliza-khu commented Apr 25, 2024

i tried adding pod 'DoubleConversion', :modular_headers => true without success.

started happening when upgrading from RN 0.73.6 to 0.74.0

Delete Podfile.lock file and perform pod install on the iOS directory fix the issue for me.
If needed fire pod update as well.

@LucidNinja
Copy link

i tried adding pod 'DoubleConversion', :modular_headers => true without success.
started happening when upgrading from RN 0.73.6 to 0.74.0

Delete Podfile.lock file and perform pod install on the iOS directory fix the issue for me. If needed fire pod update as well.

Deleting Podfile.lock and then running pod install worked for me.

@TheRogue76
Copy link
Collaborator

Tested against 0.74: https://github.com/TheRogue76/LRN1223
Not reproducible. I checked RN 74's DoubleConversion module and it indeed does define the correct modular header as of facebook/react-native#42591.
You guys probably have a cache issue. Please delete your pod directory and clear out the cache. Closing issue unless a reproducible is given for further investigation.

@TheRogue76 TheRogue76 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants