Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Command Validation] Allow 0 as valid command value #325

Open
maxekman opened this issue Jul 5, 2021 · 0 comments
Open

[Command Validation] Allow 0 as valid command value #325

maxekman opened this issue Jul 5, 2021 · 0 comments
Labels
core Core components enhancement

Comments

@maxekman
Copy link
Member

maxekman commented Jul 5, 2021

Is your feature request related to a problem? Please describe.
Sometimes it's valid to have 0 as a valid command value, as checked by CheckCommand().

Describe the solution you'd like
Would be useful to have an additional struct field to allow 0 as a valid command value: eh:”optional,allow_zero”

Describe alternatives you've considered
To always allow 0, but that would break existing API usage.

Additional context

// Don't check for zero for value types:

@maxekman maxekman added core Core components enhancement labels Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core components enhancement
Development

No branches or pull requests

1 participant