Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choice of language for Slack integration #8561

Open
despens opened this issue May 5, 2022 · 9 comments
Open

Allow choice of language for Slack integration #8561

despens opened this issue May 5, 2022 · 9 comments

Comments

@despens
Copy link

despens commented May 5, 2022

Loomio is localized to multiple languages, yet the Slack integration always seems to post messages using English labels. Maybe there could be a way to set the desired chatbot language?

@robguthrie
Copy link
Member

Oh yes, absolutely. We can add a locale select to the bot config.

@robguthrie
Copy link
Member

I've just checked on this. The chatbot will use the language, timezone and date format of the author of the notification, or the creator of the chatbot.

Will that suit your needs?

@despens
Copy link
Author

despens commented Nov 23, 2022

It won't in my particular case. I'm part of several Loomio groups that use different languages, international groups use English, local groups use the local language. If each chatbot could be configured to a locale that'd be ideal I think.

@poVoq
Copy link

poVoq commented Dec 11, 2023

Since they are linked to a specific chat channel which usually has a working language, I agree that setting the language in the webhook settings would make the most sense.

@robguthrie
Copy link
Member

We need 3 things for the chatbot: Locale (language), timezone and date format (ie: dd-mm-yy, 24/12h).

Currently it copies the settings of the user who is responsible for the notification (ie: created the poll or thread), or if there is no user responsible, the group creator's settings. It's a similar process for sending invitation emails to new users.

I was, just now, going to just add support for setting language on the chatbot form, then I saw we need timezone, and date format too - and it feels a bit much?

It would be easier (for me) to use the settings of the chatbot author. (ie: a change from the above description), and if you wanted to have a different locale, then you could setup a user with that locale and create the chatbot with that user?

That's a one line change versus implementing 3 new fields in the client form, server handling stuff and chatbot model

@poVoq
Copy link

poVoq commented Dec 11, 2023

Hmm, I guess that would be a reasonable compromise to keep it simpler as the person setting up the webhook probably speaks the language of the linked chat.

@robguthrie
Copy link
Member

Yes, and if you need you can setup a user for the purpose, then mark them as a bot (from the user profile page) so they don't affect the proposal counts

@poVoq
Copy link

poVoq commented Mar 13, 2024

So I tried this with another chat integration (xmpp) and it uses the language of the browser of the person commenting, which is quite confusing as every notification then has another language pretty much.

@robguthrie
Copy link
Member

Yeah, that logic was crazy! What was I thinking. I've fixed it just now.

811e27d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants