Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Record instance-manager name for a block disksin node.spec.diskStatus #8458

Open
Tracked by #6001
derekbit opened this issue Apr 28, 2024 · 1 comment
Assignees
Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone

Comments

@derekbit
Copy link
Member

derekbit commented Apr 28, 2024

Is your improvement request related to a feature? Please describe (馃憤 if you like this request)

This is an improvement as well as a subtask of #6001.

For a block-type disk, which is managed by an instance-manager pod (specifically, the spdk_tgt component), the proposed improvement is to record the name of the instance-manager pod that is currently managing the disk in the node.spec.diskStatus[i].instanceManagerName field. This information will help identify which instance-manager pod is responsible for a particular disk and determine if the disk is already is transferred to a new instance-manager during upgrade.

For a filesystem-type disk, the node.spec.diskStatus[i].instanceManagerName field is left empty because this type of disk is not exclusively managed by any instance-manager.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@derekbit derekbit added require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated kind/improvement Request for improvement of existing function area/v2-data-engine v2 data engine (SPDK) require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Apr 28, 2024
@derekbit derekbit added this to the v1.7.0 milestone Apr 28, 2024
@derekbit derekbit self-assigned this Apr 28, 2024
@derekbit derekbit changed the title [IMPROVEMENT] Record instance-manager name that manages the disk in the node.spec.diskStatus [IMPROVEMENT] Recording instance-manager name for a block disksin node.spec.diskStatus Apr 28, 2024
@derekbit derekbit changed the title [IMPROVEMENT] Recording instance-manager name for a block disksin node.spec.diskStatus [IMPROVEMENT] Record instance-manager name for a block disksin node.spec.diskStatus Apr 28, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Apr 28, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Create a Longhorn cluster and enable v1 and v2 data engines.
  2. Add filesystem-type and block-type disks
  3. Check filesystem-type's diskStatus.instanceManagerName is empty
  4. Check block-types's diskStatus.instanceManagerName is the running instance-manager.
  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

#8460

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2761

  • Which areas/issues this PR might have potential impacts on?
    Area: disk management, instance-manager
    Issues

@derekbit derekbit added require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated priority/0 Must be fixed in this release (managed by PO) labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
None yet
Development

No branches or pull requests

2 participants