Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Do not start any instance-manager pods for the v2 data engine on a node if one is already running #8456

Open
Tracked by #6001
derekbit opened this issue Apr 27, 2024 · 1 comment
Open
Tracked by #6001

[IMPROVEMENT] Do not start any instance-manager pods for the v2 data engine on a node if one is already running #8456

derekbit opened this issue Apr 27, 2024 · 1 comment
Assignees
@derekbit
Labels
area/v2-data-engine v2 data engine (SPDK) component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone
v1.7.0

Comments

@derekbit
Copy link
Member

Is your improvement request related to a feature? Please describe (馃憤 if you like this request)

This is an improvement as well as a subtask of #6001.

Do not start any instance-manager pods for the v2 data engine on a node if one is already running because:

  • Block-type disks are exclusively managed by a single instance-manager pod (specifically, spdk_tgt).
  • A running instance-manager pod requires 2 GiB of huge pages. Additional pods cannot be launched due to the lack of available huge pages.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@derekbit derekbit added component/longhorn-manager Longhorn manager (control plane) priority/0 Must be fixed in this release (managed by PO) require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated kind/improvement Request for improvement of existing function area/v2-data-engine v2 data engine (SPDK) require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Apr 27, 2024
@derekbit derekbit added this to the v1.7.0 milestone Apr 27, 2024
@derekbit derekbit self-assigned this Apr 27, 2024
This was referenced Apr 27, 2024
Open
Open
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Apr 27, 2024 •
edited by derekbit

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2756

  • Which areas/issues this PR might have potential impacts on?
    Area: instance manager, v2 data engine
    Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

Labels
area/v2-data-engine v2 data engine (SPDK) component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@derekbit @longhorn-io-github-bot