Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI][IMPROVEMENT] Improve the UX of updating danger zone settings #8071

Open
github-actions bot opened this issue Feb 29, 2024 · 4 comments
Open

[UI][IMPROVEMENT] Improve the UX of updating danger zone settings #8071

github-actions bot opened this issue Feb 29, 2024 · 4 comments
Assignees
Labels
area/setting Global setting or volume setting area/ui UI related like UI or CLI kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone

Comments

@github-actions
Copy link

make corresponding UI changes for #8070

cc @longhorn/dev-ui

@github-actions github-actions bot added area/setting Global setting or volume setting area/ui UI related like UI or CLI kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated labels Feb 29, 2024
@github-actions github-actions bot added this to the v1.7.0 milestone Feb 29, 2024
@a110605 a110605 assigned a110605 and unassigned scures Apr 25, 2024
@a110605
Copy link

a110605 commented May 9, 2024

@a110605
Copy link

a110605 commented May 24, 2024

After synced with @mantissahz, he will add applied field for all danger zone settings to indicate they are applied or not.

Settings page can add some descriptions in danger zone block according to the danger-zone document and show those unapplied (applied=false) setting in notification or somewhere in UI to let user know.

@mantissahz
Copy link
Contributor

related: longhorn/longhorn-manager#2820

@longhorn-io-github-bot
Copy link

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

  • Which areas/issues this PR might have potential impacts on?
    Area
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/setting Global setting or volume setting area/ui UI related like UI or CLI kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
None yet
Development

No branches or pull requests

4 participants