Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move requires out of global lib #344

Open
mroth opened this issue May 15, 2017 · 1 comment
Open

move requires out of global lib #344

mroth opened this issue May 15, 2017 · 1 comment
Labels

Comments

@mroth
Copy link
Member

mroth commented May 15, 2017

Currently, in lib/lolcommits.rb, we require all external gems and libraries at the root level of the library:

require 'mini_magick'
require 'core_ext/mini_magick/utilities'
require 'fileutils'
require 'git'
require 'open3'
require 'methadone'
require 'date'
require 'mercurial-ruby'
require 'core_ext/mercurial-ruby/shell'

We should refactor to have only the files that actually use these gem deps require them, this is best practice for a project of this size, and will aide in future refactors because we can understand where our deps actually come from.

@mroth mroth added the refactor label May 15, 2017
@matthutchinson
Copy link
Member

Agree 👍 lib/lolcommits.rb should really only require the gems' local files in lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants