-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update windows FAQ #261
Comments
I think we do still need ImageMagick. The I remember needing to jump through these hoops when I setup a VM machine with Windows for lolcommit testing recently. ... our existing README also lists imagemagick as a requirement (for OSX / Linux / Windows) |
Ah yeah, ImageMagick is still definitely needed. The stuff I was thinking could probably go had to do with getting RMagick to compile. I think since MiniMagick just shells out and is pure ruby without C extensions, we may no longer need the Ruby Development Kit or ImageMagick "development headers and libraries" options, and can potentially just use normal installs. |
Since I did this - I think we can close this now? The guide is as lean as it can be right now for a working lolcommits on windows. We can obviously update it as things change when plugins get moved out and the DevKit dependency isn't needed anymore. I was thinking of adding info on how to run tests on Windows, but until we have a passing build we can work with, I don't think there is much point. PR #278 needs release for the Windows post-commit to be fixed. Even tho we don't have many windows users at all, I think its worth releasing that as |
I think the one thing I'd like to figure out is if the Ruby Developer Kit is still required. Since we no longer use gems with C extensions (I believe?) I don't think it should be needed, which could simplify things a lot. IIRC this was just for when we were using RMagick. |
I've checked - we DO need it (for the OJ gem to install) which is a requirement from our Yammer plugin. So right now as it stands, it is required. Like I mentioned, if we move plugins out of the main gem, we won't have this dependency anymore. |
Ahhh ok. Yet another reason to move out the plugins. CC #99 so this thread shows up there. |
can close? |
I think okay to close (as long as we make testing then updating the FAQ again a completion task for #99). |
The Windows install FAQ is likely very outdated, since it looks like a good portion of it involves installing things necessary for RMagick to build:
https://github.com/mroth/lolcommits/wiki/Installing-on-Windows
Since we got rid of RMagick long ago (years even?) some of these steps are probably unnecessary now.
The text was updated successfully, but these errors were encountered: