Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of non-3D meshes #194

Open
Andres-MG opened this issue Nov 24, 2023 · 1 comment
Open

Implementation of non-3D meshes #194

Andres-MG opened this issue Nov 24, 2023 · 1 comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested

Comments

@Andres-MG
Copy link
Collaborator

The way 2D cases are handled is very confusing I think. These three attributes:

logical :: meshIs2D = .FALSE. ! Is this a 2D mesh? default .FALSE.
integer :: dir2D = 0 ! If it is in fact a 2D mesh, dir 2D stores the global direction IX, IY or IZ
integer :: dir2D_ctrl = 0 ! dir2D as in the control file

are set during the pre-processing stage to a value that depends on the keywords in the control file and the mesh itself. It seems that this is done in this function:
subroutine HexMesh_CheckIfMeshIs2D(self)

but it seems to override the choice of the user in the control file.

I will not merge #158 until this is reviewed, as the characteristic length of the elements is now wrong in 2D cases, and methods depending on it (LES, shock capturing) will provide different results.

@Andres-MG Andres-MG added help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested labels Nov 24, 2023
@loganoz loganoz pinned this issue Nov 27, 2023
@loganoz
Copy link
Owner

loganoz commented Nov 27, 2023

I have pinned this issue so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants