New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPStan deprecation tests fail. #144
Comments
Hi @rupertj thanks for the ticket; this is a valid error as classes shouldn't have the same name I'll submit a ticket against the
In the meantime I'll look at what excluding I can add to PHPStan itself. |
Hi @rupertj doing some further debugging this looks like it is caused by an update of the package This ticket covers the issue we are seeing here mglaman/phpstan-drupal#640 |
Cheers @millnut - good find! I was planning on filing issues against both modules to suggest adding a namespace to their examples, as that'd make them better examples anyway. But if you're up for it, go for it :) |
@rupertj this is now fixed in mglaman/phpstan-drupal (1.2.4), the pipeline that ran today is now green https://github.com/localgovdrupal/localgov_project/actions/runs/6874041455 |
Thanks for the update! I had to delete a runner cache to get my pipeline to run with the newer version of phpstan-drupal, but they're good now. |
I'm currently getting test failures on localgov_publications: https://github.com/localgovdrupal/localgov_publications/actions/runs/6853042624/job/18633021243
I've seen it on localgov_forms too, so this could be widespread:
https://github.com/localgovdrupal/localgov_forms/actions/runs/6852604081/job/18631575333
I've tracked the error to localgov_project.
To recreate this:
Gives the output:
This is caused by there also being an api.php file in date_recur that uses the same example classname:
I've tried to exclude *.api.php from the files that phpstan looks at, but adding this to the phpstan.neon had no effect at all.
The text was updated successfully, but these errors were encountered: