441/add media via paragraphs #442
Conversation
There was a problem hiding this comment.
Looking at the code for groupmedia how were we using it without this?
Edit: Answer we were calling it in that callback which wasn't getting the Group ID any more. Why was this preferable to enabling groupmedia standard behaviour? Cases where the standard behaviour wasn't calculating the group context correctly would be my first guess.
If we do switch though, we should remove the submit handler.
|
Sorry, not had a chance yet, but will test this soon. |
|
In one of those how did that work. The call we are making relies on a plugin being returned that <for some time requires that to be checked. So our submit handler needs it. In addition to any groupmedia attempts to attach the correct group. |
|
And this is bring stuff in from the 2.x / 3.x branches we can't use. Let me rebase it back and make a new (additional PR). |
|
So #443 for 4.x and this one for 3.x |
Closes #441