Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test inconsistently failing #432

Open
finnlewis opened this issue Apr 25, 2024 · 2 comments
Open

Test inconsistently failing #432

finnlewis opened this issue Apr 25, 2024 · 2 comments

Comments

@finnlewis
Copy link
Member

I was seeing this intermitently on localgov_microsites_group, then it started passing, now it's showing up again on localgov_microsites_project

1) Drupal\Tests\localgov_microsites_group\Functional\MicrositeCachingTest::testSiteSettings
Behat\Mink\Exception\ResponseTextException: The text "_<+q>&.(" was not found anywhere in the text of the current page.

https://github.com/localgovdrupal/localgov_microsites_project/actions/runs/8817115695/job/24202784205?pr=49#step:5:19

Any ideas ?

@opdavies
Copy link

opdavies commented Apr 28, 2024

I don't see anything obvious within the test itself unless, because it's a random string, could it be sometimes failing based on the value of the random string?

From the failing test code:

$link_title = $this->randomString();
$this->drupalGet('group/' . $this->group->id() . '/menu/2/add-link');
$this->submitForm([
  'title[0][value]' => $link_title,
  'link[0][uri]' => '<front>',
], 'Save');
$this->drupalGet($this->domain->getUrl());
$this->assertSession()->pageTextContains($link_title);

I'd like to look into https://github.com/localgovdrupal/drupal-container as it's used within the CI pipeline, and the subsequent caching step to rule out any issues there.

@opdavies
Copy link

opdavies commented May 1, 2024

Caching tests (if that's what we're talking about) isn't something I usually do as I want to avoid potential contamination between test runs.

Is the caching something we could remove, even temporarily, to see if it solves the intermittent issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants