Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date format in validation callback overrides the date format in elements that extend localgov_date element #76

Open
andybroomfield opened this issue Apr 30, 2024 · 1 comment

Comments

@andybroomfield
Copy link
Contributor

With the fix in #72 which provides a validation date format, there is a side effect that when an element that extends localgov_forms_date provides a custom date format, this is overidden by the validation method.

We noticed that you can get the validation method set correctly in the element decleration in the getInfo() decleration, setting date_date_format to the required format.

@MattOz-CDS
Copy link
Contributor

Hey @andybroomfield , thanks for highlighting this side effect. I'll follow your recommendation in order to fix it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants