Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should field.storage.node.localgov_directory_opening_times config move to the main module config? #339

Open
andybroomfield opened this issue Feb 6, 2024 · 0 comments

Comments

@andybroomfield
Copy link
Contributor

I've noticed that there are several fields that whilst the usage is defined in the provider / venue module, the main storage is in the main modules config as some of them are shared.This is different for the opening hours field.

https://github.com/localgovdrupal/localgov_directories/blob/3.x/modules/localgov_directories_venue/config/install/field.storage.node.localgov_directory_opening_times.yml

Although it's not a shared field, it does slightly complicate reusing this field in a custom directory and providing this as a module, as it requires enabling the localgov_directories_venue module. Would we consider moving this field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant