Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a Discussion about what Display Modes we want for Media #59

Open
markconroy opened this issue Apr 20, 2021 · 1 comment
Open

Have a Discussion about what Display Modes we want for Media #59

markconroy opened this issue Apr 20, 2021 · 1 comment

Comments

@markconroy
Copy link
Member

markconroy commented Apr 20, 2021

Looking at the display types for media, we have displays set for "Events thumbnail" and also "Newsroom teaser".

Let's take those 2 as an example of what not to do and why.

  1. We do not have a consistent naming convention. To fix, let's change to "Events teaser" and "Newsroom teaser".
  2. We should not need to have individual media display modes for the same content view mode - teaser. Each content type using the "Teaser" view mode should use the same "Teaser" media display mode.
  3. If we continue with the approach we currently have, and every content type wants to use a teaser image in, say, search results, we are going to have an unmanageable amount of media display modes - news teaser, event teaser, guide teaser, directory teaser, step-by-step teaser, etc
  4. Now, if we then enable another view mode - say, card, for example - and follow the same approach, we are going to have massive technical debt in the future.

This reminds me of the issues we have on the frontend as well, where different developers or councils are implementing features but without the joined up thinking of a system. While this allows features to be independent and module, it sets us up for massive headaches in the future.

@markconroy
Copy link
Member Author

Now that we have news almost ready, I'd really like to push to have a chat about this. I'd much prefer news teasers to use a media display mode called "Teaser" (and eventually events, services, directories, etc) to all use that when their content is represented in a teaser view mode.

This is scalable. Creating a view mode per content type multiplied by per content type view mode is taking us down a massive technical debt road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant