New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Original ratio" Media image view mode #49
Comments
Interesting. |
We have seen people here uploading 2+MB images. These ruin the UX when you later try to view such pages in a real mobile phone. To avoid this, a crop can impose a maximum width while retaining the original ratio thereby ensuring a reasonable image size. That's the rational in my mind. It is possible to optimize the image size further by installing the Image effects module. We used to do that in the previous Drupal 8 site although I am not proposing it here :) |
But even if I upload a 50MB file, the image styles will create the max width and scale the image proportionally, without the need for an additional crop. My thinking is, the only reason to have a crop is if you wanted to allow the content creator to upload an image and select a proportion of the image rather than the whole thing. Is that the need here? |
That's right. Sorry, my previous answer above totally missed the mark :( |
Cool, thanks for clarifying. It does make sense to me in that case! |
+1 |
There are times when the default 3:2 Responsive image style just isn't enough. The Original ratio Media view mode should help in those times. This will allow editors to apply that odd crop which none of the existing crops could cover. A good example is a map image that doesn't fit any of the given ratios:
Image source is a LocalGov Subsite page.
Implementation
Here are what we need to fully implement this:
FAO @finnlewis @lbcwebmaster @willguv
The text was updated successfully, but these errors were encountered: