Change text to mailto

[bisd]

The enquiries email address on this page is text rather than a link - I am assuming it should be a mailto?

https://demo.localgovdrupal.org/national-parks-uk/loch-lomond-and-trossachs

I wasn't able to establish which repo this issue belongs to - maybe someone could help? Thank you.

@msayoung

[markconroy]

Hi @bisd

There is currently no template for that item. It was set up originally as a text field instead of an email field for some reason.

If you want to turn it into an email field, you could duplicate the field.html.twig file and call it field--node--localgov-directory-email--localgov-directories-venue.html.twig then edit that file to make it an email link.

Note however, that that might break existing sites if they have already set an email link for this field in the node template or somewhere else (this is only a might, we'd have to test to see).

[bisd]

Thanks @markconroy. Sorry but I am not sure what you meant by it not being an email field since it seems to be an email field (please see attachment below). I have created a twig template with the suggested naming convention. I am not sure what the best way is of testing it is before it is merged but I have submitted it as a pull request anyway. Please let me know if there is anything I can do to help with the testing.

[ekes]

As it's a email field the formatter could be changed.

[ekes]

So it's the default set in LocalGov Directories in this line

https://github.com/localgovdrupal/localgov_directories/blob/f871834f2e2a60e10d5b2a2ba6a49db889a7d7c6/modules/localgov_directories_venue/config/install/core.entity_view_display.node.localgov_directories_venue.default.yml#L74

Exporting config after changing the setting from plain text to email and looking at the exported config you can see what the line should become to set it to email by default. That way is maybe easiest to make a PR against localgov_directories to change the default.

[bisd]

I have made a new pull request against localgov_directories to change the field formatter default here.

[markconroy]

Sorry, my mistake. I thought it was a text field we had here since it's format was 'plain text'.