Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pink background on unpublished pages viewed through preview links #487

Open
Adnan-cds opened this issue Sep 29, 2023 · 15 comments
Open

Pink background on unpublished pages viewed through preview links #487

Adnan-cds opened this issue Sep 29, 2023 · 15 comments

Comments

@Adnan-cds
Copy link
Contributor

#464 has brought back pink backgrounds to unpublished pages. Problem is, when such pages are shared using preview links from the "Preview Link" tab of a page, the pink background is causing confusion among recipients. People are wondering if the pink background is going to stick when the page is published later. Sample screenshot from an unpublished Guide page shared through a preview link:
screenshot-preview-link-page-pink-bg

Copying @DavidBAsch @finnlewis @markconroy @msayoung

@willguv
Copy link
Member

willguv commented Oct 10, 2023

@Adnan-cds thanks for flagging. Are you going to propose a fix for this?

I wonder (copying @stephen-cox) if this is related to the preview link issue where content designers have to share multiple links to with service contacts to get content checked.

If we were to have a "Service contact" read only user, we could remove the pink background for them.

What do you both think?

@DavidBAsch
Copy link

@willguv To be honest I don't like it at all. I find it difficult to visualise the content when editing, as well as sending to the service when it's displayed like this.

@Adnan-cds
Copy link
Contributor Author

Are you going to propose a fix for this?

Sorry, nothing in mind. Mark @markconroy asked me to raise this ticket in Slack. I thought Mark wants to fix it. If Mark is unavailable then we can try asking Chris @cjstevens78.

I wonder if this is related to the localgovdrupal/localgov#600 where content designers have to share multiple links to with service contacts to get content checked.

Not entirely related although this issue is going to affect any previewed page that is still not published.

@willguv
Copy link
Member

willguv commented Oct 10, 2023

Thanks @DavidBAsch I must admit this one went through without a lot of discussion. I assumed that it would be something everyone would want - sorry, lesson learned!

I think the next thing we should do is toggle this effect on/ off on a whole site. What do you think? Copying @markconroy as he might be able to do the work

Thanks all

@DavidBAsch
Copy link

@willguv It might just be me that doesn't like it, though 🤔

@andybroomfield
Copy link

Just to add, this is how we do it at Brighton. I think it's important that we have some indication that a page is unpublished. We could look at donoring this after the Drupal 10 work as it's quite straight forword.

Screenshot 2023-10-10 at 12 29 11 pm

@DavidBAsch
Copy link

If the purpose is to make people aware it's still in draft then perhaps something like:

Your service page [DRAFT]

Content
.......

Would be better than this:

image

@markconroy
Copy link
Member

I really like @andybroomfield's approach. A banner across the top saying "This page is not published ..."

@stephen-cox
Copy link
Member

+1 for a banner making it clear the page is unpublished.

@DavidBAsch
Copy link

DavidBAsch commented Oct 30, 2023

The problem I see (or don't see) with banners is they could easily be obscured by live site banners.

image

@andybroomfield
Copy link

Make it in page like a system message?

@markconroy
Copy link
Member

We have a new approach to this now based on #495

If anyone wants to create the message banner proposed in this issue as an extra bonus feature, that would be cool.

@willguv
Copy link
Member

willguv commented Nov 13, 2023

Maybe the banner is at the very top of the page? It could be an option, same as pink background and appending the word [DRAFT]

Thanks in advance for donating if you do it @andybroomfield - much obliged!

@markconroy
Copy link
Member

Any thoughts on how the banner approach might work when the unpublished page is an entity reference/teaser inside another page (which may or may not also be unpublished)?

@Adnan-cds
Copy link
Contributor Author

If it helps, on Service landing pages and Service sublanding pages, we mark unpublished child pages as "Unpublished". Screenshot follows:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants