New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pink background on unpublished pages viewed through preview links #487
Comments
@Adnan-cds thanks for flagging. Are you going to propose a fix for this? I wonder (copying @stephen-cox) if this is related to the preview link issue where content designers have to share multiple links to with service contacts to get content checked. If we were to have a "Service contact" read only user, we could remove the pink background for them. What do you both think? |
@willguv To be honest I don't like it at all. I find it difficult to visualise the content when editing, as well as sending to the service when it's displayed like this. |
Sorry, nothing in mind. Mark @markconroy asked me to raise this ticket in Slack. I thought Mark wants to fix it. If Mark is unavailable then we can try asking Chris @cjstevens78.
Not entirely related although this issue is going to affect any previewed page that is still not published. |
Thanks @DavidBAsch I must admit this one went through without a lot of discussion. I assumed that it would be something everyone would want - sorry, lesson learned! I think the next thing we should do is toggle this effect on/ off on a whole site. What do you think? Copying @markconroy as he might be able to do the work Thanks all |
@willguv It might just be me that doesn't like it, though 🤔 |
I really like @andybroomfield's approach. A banner across the top saying "This page is not published ..." |
+1 for a banner making it clear the page is unpublished. |
Make it in page like a system message? |
We have a new approach to this now based on #495 If anyone wants to create the message banner proposed in this issue as an extra bonus feature, that would be cool. |
Maybe the banner is at the very top of the page? It could be an option, same as pink background and appending the word [DRAFT] Thanks in advance for donating if you do it @andybroomfield - much obliged! |
Any thoughts on how the banner approach might work when the unpublished page is an entity reference/teaser inside another page (which may or may not also be unpublished)? |
#464 has brought back pink backgrounds to unpublished pages. Problem is, when such pages are shared using preview links from the "Preview Link" tab of a page, the pink background is causing confusion among recipients. People are wondering if the pink background is going to stick when the page is published later. Sample screenshot from an unpublished Guide page shared through a preview link:
Copying @DavidBAsch @finnlewis @markconroy @msayoung
The text was updated successfully, but these errors were encountered: