Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using the localgov-page-section template for page-sections #314

Open
msayoung opened this issue Nov 2, 2022 · 2 comments
Open

using the localgov-page-section template for page-sections #314

msayoung opened this issue Nov 2, 2022 · 2 comments

Comments

@msayoung
Copy link
Member

msayoung commented Nov 2, 2022

In #291 we added paragraph--page-section.html to use the same template as the new localgov_page_section

Remind me why we wanted to do this @markconroy ?

I've got some broken layouts which i suspect I can fix, but just wanted to check the motivation.

@markconroy
Copy link
Member

I can't remember explicitly. But I think it had something to do with localgov_page_section needing one template, but if others create the same funcationality (since we are not providing an update hook to get this funcationality) then they will need paragraph--page-section template.

I could be wrong, but I think it's something like that.

@markconroy
Copy link
Member

@msayoung shall we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants