Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert banners are loaded unnecessarily. #320

Closed
rupertj opened this issue May 2, 2024 · 0 comments · Fixed by #321
Closed

Alert banners are loaded unnecessarily. #320

rupertj opened this issue May 2, 2024 · 0 comments · Fixed by #321

Comments

@rupertj
Copy link
Member

rupertj commented May 2, 2024

The block that displays alert banners loads the banners in its constructor, which means they're loaded on pages that they don't need to be: EG, any cached page, or the blocks admin screen. Also, the build method re-loads them, so they're loaded twice in situations where they only needed to be loaded once.

PR incoming...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant