Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation for alert banner not displaying (Originally on drupal.org) #318

Closed
andybroomfield opened this issue Apr 30, 2024 · 0 comments · Fixed by #319
Closed

Translation for alert banner not displaying (Originally on drupal.org) #318

andybroomfield opened this issue Apr 30, 2024 · 0 comments · Fixed by #319
Assignees
@andybroomfield

Comments

@andybroomfield
Copy link
Contributor

Original issue
https://www.drupal.org/project/localgov/issues/3427615

Problem/Motivation
Translations of alert banners are not being displayed.

Steps to reproduce

  1. Create a new alert banner in English and publish it.
  2. Translate it to a different language.
  3. Specify in which pages the banner should be displayed.
  4. Publish it.

Expected result: The original banner will be displayed in the English pages and so will be the translation in the language specific pages.
Actual result: Only the original banner is displayed.

This happens because AlertBannerEntity::isVisible() is considering the conditions of the original banner, not the translation's.

adinancenci Also provided a patch to test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andybroomfield andybroomfield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Translation for alert banner not displaying localgovdrupal/localgov_alert_banner
1 participant
@andybroomfield