Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a local task tab for "Alert Banners" for group module #312

Closed
markconroy opened this issue Mar 11, 2024 · 13 comments
Closed

Add a local task tab for "Alert Banners" for group module #312

markconroy opened this issue Mar 11, 2024 · 13 comments
Assignees

Comments

@markconroy
Copy link
Member

At the moment, if you want to create an alert banner you need to go to yoursite.com/group/{group_id}/alert-banner/create but there is no way to know that is where you need to go unless you read through the code and find the route definition for this.

Can we add a new tab for 'Alert banners' in group_alert_banner module to

  1. Create a tab called 'Alert banners'
  2. Links to a page that lists all the alert banners for that group (if there is any)
  3. Has action links for "Add new alert banner" and "Add existing alert banner" (same as our "Content" tab does for nodes
@andybroomfield
Copy link
Contributor

@Adnan-cds as your more familliar with this, would you be able to look?

@markconroy
Copy link
Member Author

Hi @Adnan-cds

Just wondering if you happen to have any time to take a look at this issue?

@Adnan-cds
Copy link
Contributor

Sorry, Mark. I was off for nearly two weeks. I will try to look into it this week.

@markconroy
Copy link
Member Author

Oh super. Thanks very much Adnan. Hope you had a nice time away.

@Adnan-cds
Copy link
Contributor

Hi Mark,
Time away was so so :) I am just looking into this in one of our microsites and it seems to do as you have asked for in points 1-3 above. Wondering if I have misunderstood :( Here is what I see:

At /group/N:
microsites-menu-with-highlighted-alert-banner

At /group/N/alert-banners:
microsites-alert-banner-action

Please confirm.

@markconroy
Copy link
Member Author

I'm still missing those tabs @Adnan-cds and also I get a 404 at group/1/alert-banners

Screenshot 2024-04-30 at 10 19 57

Screenshot 2024-04-30 at 10 20 18

@Adnan-cds
Copy link
Contributor

Could you please check what version of the localgov_alert_banner module this site is on?

@markconroy
Copy link
Member Author

It's 1.7.4.

And it's a fresh install of the module.

@Adnan-cds
Copy link
Contributor

Thanks for confirming. Sorry, I should have asked this before. Is this site on localgov_microsites:3.x or localgov_microsites:4.x?

@markconroy
Copy link
Member Author

I think it's microsites 2. It's still on Drupal 9, so maybe that's the issue.

@Adnan-cds
Copy link
Contributor

Okay, do me a favour and try on localgov_microsites:3.x and see if it works. Finn has discovered an issue with localgov_microsites:4.x and I have raised a fix which is pending review. So localgov_microsites:3.x is the safest bet right now. We can look into a work-around for localgov_microsites:2.x if the site you are working on cannot be upgraded immediately. But first try on a fresh site which is on localgov_microsites:3.x.

@willguv
Copy link
Member

willguv commented Apr 30, 2024

Thanks for looking at this @Adnan-cds much appreciated!

@markconroy
Copy link
Member Author

Hi @Adnan-cds

Thanks very much. Sorry it's taken me a bit of time to get back to testing this, I was off all last month.

Testing this on Microsites V3 is working fine. So once the microsites I was working on that was on V2 is upgraded, it should be fine as well.

Screenshot 2024-05-22 at 14 01 52

===
Thanks to Big Blue Door for sponsoring my time to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants