Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the getCurrentAlertBanners method to a service #261

Open
andybroomfield opened this issue Jun 30, 2023 · 0 comments
Open

Move the getCurrentAlertBanners method to a service #261

andybroomfield opened this issue Jun 30, 2023 · 0 comments
Labels
Milestone

Comments

@andybroomfield
Copy link
Contributor

This is the method that is currently inside the block class, but if we wanted to call this elsewhere it would be handy to have this as a separate service that can be called, with the block altered to call the service.

It should also be possible to

  • Filter banners by type (currently this is supported by fetching block config)
  • Include additional banners that aren't yet published (For supporting better banner previews)
  • Exclude certain banners
@andybroomfield andybroomfield added this to the v1.8 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant