Alert banner with empty Link text should show "More information", but nothing shows

[keelanfh]

On a clean install with localgov_base, there's this wording when creating an Alert banner ("If you don't write anything here, we will use: More information").

But looking at the banner on the site, I see no link at all:

[andybroomfield]

With the default theme set to oliveo, the More information link is displayed.
Maybe this is an issue with Localgov base?

[andybroomfield]

And a test on BHCC theme

[andybroomfield]

This is set by localgov_alert_banner.page.inc

// Set default link text if field exists.
  if ($entity->hasField('link')) {
    if ($entity->get('link')->title === '') {
      $variables['content']['link'] = Link::fromTextAndUrl(t('More information'), Url::fromUri($entity->get('link')->uri))->toString();
    }
  }

Is localgov_base overriding this @markconroy ?

[ctorgalson]

@andybroomfield sort of. It's that the existing assignment to $variables['content']['link'] quoted above changes the render array to from a LinkItem to a GeneratedLink, I believe.

@petrillek just noticed this too. I'll create a PR in a few minutes.