Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace alert banner title with administrive title, add optional title field for display? #136

Open
andybroomfield opened this issue May 11, 2021 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@andybroomfield
Copy link
Contributor

Titles are needed for the alert banner for the admin view, and for implementing the gov.uk pattern.
However not all alerts need a title to be displayed, and sometimes the headers can be handled with the wysiwyg field.

If this change was carried forward, the change would be:

  • Change the title field to Administrive Title (like blocks)
  • Add a new field (Title) to the default bundled alert banner
  • If the display title is blank, don't display that in the template (Remove the display title checkbox)
@andybroomfield andybroomfield added enhancement New feature or request question Further information is requested labels May 11, 2021
@willguv
Copy link
Member

willguv commented May 11, 2021

@andybroomfield good suggestion. Titles aren’t used by many, so should be optional

@andybroomfield
Copy link
Contributor Author

This might be comming back up as an issue as BHCC new pattern removes the titles from display.
We still need a title in the admin interface though, otherwise it gets labelled as banner 1, banner 2 etc... Hard to spot in an emergency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants