Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offload: PluginManager.h:16:10: fatal error: 'PluginInterface.h' file not found #91881

Closed
sylvestre opened this issue May 12, 2024 · 2 comments
Closed

offload: PluginManager.h:16:10: fatal error: 'PluginInterface.h' file not found #91881

sylvestre opened this issue May 12, 2024 · 2 comments
Labels
build-problem offload

Comments

@sylvestre
Copy link
Collaborator

sylvestre commented May 12, 2024 •
edited

On debian sid on i386


FAILED: offload/src/CMakeFiles/omptarget.dir/omptarget.cpp.o 
/build/source/build-llvm/bin/clang++ --target=i386-linux-gnu -DDEBUG_PREFIX=\"omptarget\" -DENABLED_OFFLOAD_PLUGINS="" -DTARGET_NAME=omptarget -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/source/llvm/include -I/build/source/build-llvm/include -I/build/source/offload/include -I/build/source/build-llvm/runtimes/runtimes-bins/offload/include -fstack-protector-strong -Wformat -Werror=format-security -Wno-unused-command-line-argument -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fdebug-prefix-map=/build/source/build-llvm/runtimes/runtimes-bins=../../../ -fdebug-prefix-map=/build/source/= -no-canonical-prefixes -ffile-prefix-map=/build/source/build-llvm/runtimes/runtimes-bins=../../../ -ffile-prefix-map=/build/source/= -no-canonical-prefixes -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-exceptions -MD -MT offload/src/CMakeFiles/omptarget.dir/omptarget.cpp.o -MF offload/src/CMakeFiles/omptarget.dir/omptarget.cpp.o.d -o offload/src/CMakeFiles/omptarget.dir/omptarget.cpp.o -c /build/source/offload/src/omptarget.cpp
In file included from /build/source/offload/src/omptarget.cpp:15:
In file included from /build/source/offload/include/OffloadPolicy.h:17:
/build/source/offload/include/PluginManager.h:16:10: fatal error: 'PluginInterface.h' file not found
   16 | #include "PluginInterface.h"
      |          ^~~~~~~~~~~~~~~~~~~
1 error generated.
@llvmbot
Copy link
Collaborator

llvmbot commented May 12, 2024

@llvm/issue-subscribers-offload

Author: Sylvestre Ledru (sylvestre)

On debian sid: ```

FAILED: offload/src/CMakeFiles/omptarget.dir/omptarget.cpp.o
/build/source/build-llvm/bin/clang++ --target=i386-linux-gnu -DDEBUG_PREFIX="omptarget" -DENABLED_OFFLOAD_PLUGINS="" -DTARGET_NAME=omptarget -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/source/llvm/include -I/build/source/build-llvm/include -I/build/source/offload/include -I/build/source/build-llvm/runtimes/runtimes-bins/offload/include -fstack-protector-strong -Wformat -Werror=format-security -Wno-unused-command-line-argument -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fdebug-prefix-map=/build/source/build-llvm/runtimes/runtimes-bins=../../../ -fdebug-prefix-map=/build/source/= -no-canonical-prefixes -ffile-prefix-map=/build/source/build-llvm/runtimes/runtimes-bins=../../../ -ffile-prefix-map=/build/source/= -no-canonical-prefixes -O3 -DNDEBUG -std=c++17 -fPIC -fno-exceptions -funwind-tables -fno-exceptions -MD -MT offload/src/CMakeFiles/omptarget.dir/omptarget.cpp.o -MF offload/src/CMakeFiles/omptarget.dir/omptarget.cpp.o.d -o offload/src/CMakeFiles/omptarget.dir/omptarget.cpp.o -c /build/source/offload/src/omptarget.cpp
In file included from /build/source/offload/src/omptarget.cpp:15:
In file included from /build/source/offload/include/OffloadPolicy.h:17:
/build/source/offload/include/PluginManager.h:16:10: fatal error: 'PluginInterface.h' file not found
16 | #include "PluginInterface.h"
| ^~~~~~~~~~~~~~~~~~~
1 error generated.

</details>

@sylvestre sylvestre mentioned this issue May 12, 2024
Closed
@jhuber6
Copy link
Contributor

jhuber6 commented May 13, 2024

Hm, it's not including the plugins directory. I believe it inherits that from including one of the plugins, so maybe none of them are being built? How was i386 used previously? My understanding was that we only supported 64-bit systems.

jhuber6 added a commit to jhuber6/llvm-project that referenced this issue May 15, 2024
@jhuber6
[Offload] Correctly reject building on unsupported architectures
e3de5b4 
Summary:
Previously we had this `LIBOMPTARGET_ENABLED` variable which controlled
including `libomptarget`. This is now redundant since it's controlled by
`LLVM_ENABLE_RUNTIMES`. However, this had the extra effect of not
building it when given unsupported targets. THis was lost during the
move to `offload`. This patch moves this logic back and makes the
`offload` target just quit without doing anything if used on an
unsupported architecture.

llvm#91881
llvm#91819
@jhuber6 jhuber6 mentioned this issue May 15, 2024
Merged
jhuber6 added a commit that referenced this issue May 15, 2024
@jhuber6 @sylvestre
[Offload] Correctly reject building on unsupported architectures (#92276
332de4b 
)

Summary:
Previously we had this `LIBOMPTARGET_ENABLED` variable which controlled
including `libomptarget`. This is now redundant since it's controlled by
`LLVM_ENABLE_RUNTIMES`. However, this had the extra effect of not
building it when given unsupported targets. THis was lost during the
move to `offload`. This patch moves this logic back and makes the
`offload` target just quit without doing anything if used on an
unsupported architecture.

#91881
#91819

---------

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
@jhuber6 jhuber6 closed this as completed May 16, 2024
mub-at-arm pushed a commit to mub-at-arm/llvm-project that referenced this issue May 16, 2024
@jhuber6 @sylvestre @mub-at-arm
[Offload] Correctly reject building on unsupported architectures (llv…
de39ce9 
…m#92276)

Summary:
Previously we had this `LIBOMPTARGET_ENABLED` variable which controlled
including `libomptarget`. This is now redundant since it's controlled by
`LLVM_ENABLE_RUNTIMES`. However, this had the extra effect of not
building it when given unsupported targets. THis was lost during the
move to `offload`. This patch moves this logic back and makes the
`offload` target just quit without doing anything if used on an
unsupported architecture.

llvm#91881
llvm#91819

---------

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-problem offload
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sylvestre @jhuber6 @llvmbot