Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pytest plugin #1522

Closed
wants to merge 4 commits into from
Closed

Conversation

mheguy-flo
Copy link
Contributor

This resolves the issue with code coverage and all tests pass, but I don't know if it does/will have a negative impact on the plugin itself for end users.

Closes #1489

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Merging #1522 (83b6d71) into master (95a1d70) will increase coverage by 41.67%.
Report is 2 commits behind head on master.
The diff coverage is 62.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1522       +/-   ##
===========================================
+ Coverage   57.08%   98.76%   +41.67%     
===========================================
  Files          60       59        -1     
  Lines        2123     2103       -20     
===========================================
+ Hits         1212     2077      +865     
+ Misses        911       26      -885     

@lk-geimfari
Copy link
Owner

lk-geimfari commented Mar 25, 2024

Seems like it didn't fixed that issue: https://app.codecov.io/gh/lk-geimfari/mimesis/pull/1522

@mheguy-flo
Copy link
Contributor Author

Sorry about that. I must have gotten mixed up between stashes at one point.

Copy link
Collaborator

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that the current pyproject.toml won't include this folder into the ending build.

Plus, pytest_plugin name is too generic. Maybe mimesis_pytest_plugin?

@mheguy-flo
Copy link
Contributor Author

With the latest commits, this is what it looks like after a pip install:
image

I don't know if this is how you guys want it / how it should be.

@mheguy-flo mheguy-flo closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov reporting wrong coverage information.
3 participants