Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify reasons for disabling TS rules (and consider re-enabling some) #757

Open
axelboc opened this issue Apr 18, 2023 · 1 comment
Open
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@axelboc
Copy link
Contributor

axelboc commented Apr 18, 2023

Galex disables a lot of rules when TypeScript is enabled, to avoid reporting the same problems twice. This is mostly the case when:

However, I've found a few cases where the reason for disabling the rule is unclear:

In other cases, rules are disabled assuming (implicitly) that some configuration options are set in tsconfig.json:

I didn't have an exhaustive look through all the rules, so the lists may not be exhaustive. So it seems that some of them could be enabled, and for the rest, perhaps it would be good to always indicate a reason for disabling in the comments, like handled by @types/react, assumes "importsNotUsedAsValues": "error", etc.

@ljosberinn
Copy link
Owner

just wanna acknowledge the issue, quite busy atm but I haven't forgotten about this, thank you :)

@ljosberinn ljosberinn added bug Something isn't working documentation Improvements or additions to documentation labels Apr 28, 2023
@ljosberinn ljosberinn mentioned this issue May 10, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants