fix: adjust lambda_stmt statement tracking
#128
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Refactoring
PR Summary: The pull request introduces a change in the query construction logic within the advanced_alchemy repository, specifically adjusting the way statements are modified to use a different method for applying conditions to queries. The change affects both the asynchronous and synchronous versions of a method responsible for filtering queries based on a given expression.
Decision: Comment
📝 Type: 'Refactoring' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Verify that the change from
filtertowherealigns with the intended behavior of the queries and that it does not introduce any regressions or changes in the semantics of the queries that could affect the application's functionality. - Consider providing additional context in the PR description about why the change from
filtertowhereis necessary and what benefits it brings to the codebase. - Review the use of lambda functions for in-place statement modification to ensure that this approach is the most readable and maintainable. If not, consider refactoring to a more explicit form of statement construction.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
cofin
changed the title
lambda_stmt adjustmentslambda_stmt statement tracking
|
|
Documentation preview will be available shortly at https://jolt-org.github.io/advanced-alchemy-docs-preview/128 |
This PR disable the tracking of statements that alter the column projections on the following functions:
This statement was causing errors when re-using lambdas for multiple queries.
Resolves #126 #120