Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate auth url encoded in /_external-auth-%v? #7

Open
oliverbarnes opened this issue May 6, 2020 · 0 comments
Open

Validate auth url encoded in /_external-auth-%v? #7

oliverbarnes opened this issue May 6, 2020 · 0 comments

Comments

@oliverbarnes
Copy link
Member

oliverbarnes commented May 6, 2020

It turns out nginx ingress' external authentication tacks on an unexpected extra _external-auth-xxxx path to the subrequest sent to the auth-url. 9bf59d8 handles it, but ignores an encoded string at its end.

This string seems to be the auth-url itself, encoded:

https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/template/template.go#L428

My initial guess (haven't found any documentation regarding it) would be this is a way to check that the subrequest is indeed coming from the ingress and not from somewhere else. If so, validating it against the domain assigned to the service in k8s would be an extra layer of security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant