New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard-coded salt #1

Open

igormukhingmailcom opened this issue Sep 14, 2015 · 3 comments

igormukhingmailcom commented Sep 14, 2015

Hard-coded salt:
https://github.com/userbase-project/userbase-client-php/blob/master/src/User.php#L37

We need leave it empty and throw exception if it not provided.

Contributor

h-wang commented Sep 14, 2015

@igormukhingmailcom totally agree. We should configure it in parameters.yml probably.
@igormukhingmailcom can you work on it? thanks.

Author

igormukhingmailcom commented Sep 14, 2015

@h-wang I'm planning to upgrade this lib too :)

Contributor

h-wang commented Sep 14, 2015

@igormukhingmailcom thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment