Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storageType field to HouseTable Entity #80

Closed
ctrezzo opened this issue Apr 22, 2024 · 0 comments · Fixed by #81
Closed

Add storageType field to HouseTable Entity #80

ctrezzo opened this issue Apr 22, 2024 · 0 comments · Fixed by #81

Comments

@ctrezzo
Copy link
Contributor

ctrezzo commented Apr 22, 2024

Now that there is a new storageType field we should add it to the HouseTable entity as well.
ctrezzo added a commit to ctrezzo/openhouse that referenced this issue Apr 22, 2024
@ctrezzo
Add storageType field to HouseTable Entity linkedin#80
8ff7d67
@ctrezzo ctrezzo mentioned this issue Apr 25, 2024
Merged
17 tasks
HotSushi added a commit that referenced this issue May 7, 2024
@ctrezzo @HotSushi
Add storageType field to HouseTable Entity (#81)
d8d136b 
## Summary

<!--- HINT: Replace #nnn with corresponding Issue number, if you are
fixing an existing issue -->

[Issue](https://github.com/linkedin/openhouse/issues/#80) Added a
storageType field to the HouseTable Entity to support multiple storage
types.

Resolves #80 

## Changes

- [ ] Client-facing API Changes
- [ ] Internal API Changes
- [ ] Bug Fixes
- [x] New Features
- [ ] Performance Improvements
- [ ] Code Style
- [ ] Refactoring
- [ ] Documentation
- [x] Tests

For all the boxes checked, please include additional details of the
changes made in this pull request.

Added storageType field to the HouseTable DTO.

## Testing Done
<!--- Check any relevant boxes with "x" -->

- [ ] Manually Tested on local docker setup. Please include commands
ran, and their output.
- [ ] Added new tests for the changes made.
- [x] Updated existing tests to reflect the changes made.
- [ ] No tests added or updated. Please explain why. If unsure, please
feel free to ask for help.
- [ ] Some other form of testing like staging or soak time in
production. Please explain.

For all the boxes checked, include a detailed description of the testing
done for the changes made in this pull request.

# Additional Information

- [ ] Breaking Changes
- [ ] Deprecations
- [ ] Large PR broken into smaller PRs, and PR plan linked in the
description.

For all the boxes checked, include additional details of the changes
made in this pull request.

---------

Co-authored-by: Sushant Raikar <sraikar@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add storageType field to HouseTable Entity ctrezzo/openhouse
1 participant
@ctrezzo