Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect normalize method #40

Open
earthgecko opened this issue Jan 8, 2018 · 0 comments
Open

incorrect normalize method #40

earthgecko opened this issue Jan 8, 2018 · 0 comments

Comments

@earthgecko
Copy link
Contributor

Unless there is a specific reason for only using the max value to normalize the values with, the normalize function could do with being normalized or renamed if the current normalize method is the desired method of "normalization" as it is not what is generally accepted as normalizing, just using the max that is.

Although this normalize method does return all the values between 0 and 1, for a positive values set, it does not normalize the data if there are negative values in the set, this could skew correlations and seeing as the average is being applied, arguably normalize is being incorrectly calculated.

earthgecko added a commit to earthgecko/luminol that referenced this issue Jan 8, 2018
References - incorrect normalize method linkedin#40
This was referenced Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant