Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a meaningful error when there's a syntax mistake in composes #474

Open
ramitha opened this issue Aug 10, 2020 · 1 comment
Open

Throw a meaningful error when there's a syntax mistake in composes #474

ramitha opened this issue Aug 10, 2020 · 1 comment
Labels
@css-blocks/core Issue with the core CSS Blocks library
Projects
LinkedIn GA

Comments

@ramitha
Copy link
Contributor

ramitha commented Aug 10, 2020

Currently, composes: a-block[type=butcher] (value is not in quotes) results in an error that's not meaningful, like the following.


[css-blocks] BlockSyntaxError: No Block named "b-block" found in scope. (xxx/card.block.scss:18:3)```

We should throw an error that suggest a quoting the value instead.
@ramitha ramitha added the @css-blocks/core Issue with the core CSS Blocks library label Aug 10, 2020
@ramitha
Copy link
Contributor Author

ramitha commented Aug 11, 2020 •
edited

Perhaps support composes: 'text-body[weight=bold][size=small]'; in addition to composes: 'text-body[weight=bold]', 'text-body[size=small]'

@chriseppstein chriseppstein added this to To Do in LinkedIn GA Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@css-blocks/core Issue with the core CSS Blocks library
Projects
LinkedIn GA
  
To Do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramitha