Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document invariants and edge cases #470

Open
PoignardAzur opened this issue Feb 26, 2024 · 2 comments
Open

Document invariants and edge cases #470

PoignardAzur opened this issue Feb 26, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@PoignardAzur
Copy link
Contributor

Right now I have two in mind:

  • What happens when we pass a transform matrix with NaN values to the Scene?
  • What happens if a push_layer isn't matched by a pop_layer?

Not sure if there are others.
@PoignardAzur PoignardAzur changed the title Document invariant and edge cases Document invariants and edge cases Feb 26, 2024
@dfrg
Copy link
Collaborator

dfrg commented Feb 29, 2024

  • bad things will happen
  • we should always generate a valid encoding. Open layers will be automatically closed at resolve time to ensure a balanced clip stack

@simbleau simbleau added the documentation Improvements or additions to documentation label Mar 4, 2024
@PoignardAzur
Copy link
Contributor Author

Other invariant:

  • The scene should be non-empty.

See also https://xi.zulipchat.com/#narrow/stream/197075-gpu/topic/0.20size.20buffer.20on.20WASM.20error/near/426655052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dfrg @PoignardAzur @simbleau