Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: support prometheus query language #1001

Open
stone1100 opened this issue Dec 12, 2023 · 3 comments
Open

[feature]: support prometheus query language #1001

stone1100 opened this issue Dec 12, 2023 · 3 comments
Assignees
Labels
feature New feature

Comments

@stone1100
Copy link
Member

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@stone1100 stone1100 added the feature New feature label Dec 12, 2023
@joyant
Copy link
Contributor

joyant commented Dec 12, 2023

Two questions:

  1. Should we create a dedicated port, 9090, for Prometheus SDK, or build upon the existing 9000 port?
  2. Should query results conform to the Lindb data structure or should they fully comply with the Prometheus SDK data structure?

@stone1100
Copy link
Member Author

stone1100 commented Dec 13, 2023

  1. I should be ok to build upon 9000, add a new api to support PromQL.
  2. I think support prometheus data structure for query result set is better, because user can reuse grafana dashboard.

Read, tow options

  • Support prometheus remote read
  • Implement PromQL
    I think implementing PromQL is better because user needn't deploy prometheus, but more complex.

Write:
Support prometheus remote write.

@joyant
Copy link
Contributor

joyant commented Dec 14, 2023

I have also reviewed some materials, and it seems that Prometheus remote write and implementing PromQL appear to be better solutions. If you think it's okay, please assign the task to me.

@stone1100 stone1100 assigned stone1100 and joyant and unassigned stone1100 Dec 14, 2023
joyant added a commit to joyant/lindb that referenced this issue Jan 22, 2024
joyant added a commit to joyant/lindb that referenced this issue Jan 30, 2024
joyant added a commit to joyant/lindb that referenced this issue Jan 30, 2024
joyant added a commit to joyant/lindb that referenced this issue Jan 30, 2024
stone1100 pushed a commit that referenced this issue Jan 31, 2024
* [feat:#1001]: support promql

* [feat:#1001]: ensure code passes lint checks

* [bug:#1001]: fix nakedret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants