Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make this into an injectable module #3

Open
thatkookooguy opened this issue Aug 7, 2016 · 4 comments
Open

make this into an injectable module #3

thatkookooguy opened this issue Aug 7, 2016 · 4 comments

Comments

@thatkookooguy
Copy link

right now, the code isn't prepared to be included in a project.

are you planning to do something like that?

@thatkookooguy
Copy link
Author

I would love to inject this into my open-source app

@likethemammal
Copy link
Owner

What sort of API would want the module to have?

@thatkookooguy
Copy link
Author

thatkookooguy commented Aug 11, 2016

A standard one I guess?

maybe just have something like this?

var audio = new Audio('http://audio-source...');
var visualization = new AudioVisualizer(audio);
visualization.setElement('.visualization-container');

maybe even something like:

var visualization = new AudioVisualizer({
  audio: new Audio('http://audio-source...'),
  element: '.visualization-container'
});

It should be clear what a user should do to add this thing to his\her project (ofc, that's only if you want this module to be easily included in other projects)

@likethemammal
Copy link
Owner

Sorry, thought I already replied to this.

I don't plan on adding any additions to this project for a few months. This will be one of the first additions I'll be adding tho. I'll put more thought into what the API would include and put something together that would have some longevity to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants