Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations (and public ressources) #12

Open
skydiablo opened this issue Nov 9, 2011 · 9 comments
Open

Translations (and public ressources) #12

skydiablo opened this issue Nov 9, 2011 · 9 comments

Comments

@skydiablo
Copy link

What about Translations ? If i use another theme, i want to load another translation-file too! it is possible to regard this too ? or maybe some workarounds ?

greez,
sky...

@lsmith77
Copy link
Contributor

lsmith77 commented Nov 9, 2011

hmm i would suggest to simply make the translation key dynamic

@Koc
Copy link
Contributor

Koc commented Nov 9, 2011

no way until this symfony/symfony#971 will be resolved

@lsmith77
Copy link
Contributor

lsmith77 commented Nov 9, 2011

i must admit i am a backend guy, so i don't know the entire translation stuff all that well.

@skydiablo
Copy link
Author

hiho!
some cognitions ?

@lsmith77
Copy link
Contributor

i currently do not have the intention to work on this .. i recognize that for theming other aspects might also be necessary .. so if someone cooks up a proposal i am willing to evaluate it.

@Koc
Copy link
Contributor

Koc commented Aug 18, 2012

I am propose change current directory structure to something like this

app
    Resources
        themes
            %theme_name%
                views
                public
                translations

this is BC-break, because now templates located directly at %theme_name% and after this cnahge would at %theme_name%/views. But this is very natural that theme has own public resources.

I can work on this issue if you approove this proposal.

@Koc
Copy link
Contributor

Koc commented Aug 31, 2012

So what do you think about my proposal?

@lsmith77
Copy link
Contributor

i am open to this change .. since added some flexibility in the order of directories, we might even be able to keep BC.

btw there is also https://github.com/Sylius/SyliusThemingBundle from which we might be able to draw some inspiration. IIRC the bundle was once even based on this bundle.

@dirkluijk
Copy link

+1 for including (public) assets as well.

A theme is more than just views, it would be great if any resource can live inside a theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants