Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation mismatch for TX & OP result code #154

Open
cyberluke opened this issue Nov 14, 2018 · 1 comment
Open

Documentation mismatch for TX & OP result code #154

cyberluke opened this issue Nov 14, 2018 · 1 comment
Milestone

Comments

@cyberluke
Copy link

cyberluke commented Nov 14, 2018

Here the table shows column Error and column Code:
https://www.stellar.org/developers/guides/concepts/transactions.html

Column Code is number here.

But Java SDK returns code as string:
response.getExtras().getResultCodes().getTransactionResultCode()

So if it is String, then it's not Result Code from documentation, but more likley the Error (text) column, right?

WRONG!

Because here is another documentation: https://www.stellar.org/developers/horizon/reference/errors/transaction-failed.html

And it shows:

    "envelope_xdr": "...",
    "result_xdr": "...",
    "result_codes": {
      "transaction": "tx_failed",
      "operations": [ "op_bad_auth" ]
    }
  }

Which is 3rd representation and this is nowhere documented. Here it shows you use string as result code , but you use some undocumented textual representation. Where in documentation is mentioned "tx_" and "op_" prefix? Is this rule or exception? Are there any other possible prefixes in result codes? Do you have any documentation for SDK how to handle these result codes and best practices?

@nullstyle nullstyle added this to the v0.7.0 milestone Apr 17, 2019
@overcat
Copy link
Member

overcat commented Nov 14, 2023

Current users can find all possible code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@nullstyle @cyberluke @overcat and others