Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On login, copying formatted emails from slack throws email is not valid error #10037

Open
rephus opened this issue May 10, 2024 · 1 comment
Open
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience

Comments

@rephus
Copy link
Collaborator

rephus commented May 10, 2024

Description

This was a unexpected bug in the frontend on login.

The same email, throws a different error if the emails was copied from slack. I'm still not sure how to replicate this "bad strings" with another email, but copying it from this thread fails all the time.https://lightdash.slack.com/archives/C071TU6FZ3P/p1715209151450089?thread_ts=1715205246.461809&cid=C071TU6FZ3P

Email is correct, it does a backend request to check login and password:
Screenshot from 2024-05-10 16-47-40

Copied and modified email, it shows not valid in the fronted:
Screenshot from 2024-05-10 16-49-55

We should probably do a sanitization or something. We could check what's the value in the imput, see if the htmlEncode is different.

Thread: https://lightdash.slack.com/archives/C071TU6FZ3P/p1715351576209839?thread_ts=1715205246.461809&cid=C071TU6FZ3P

Steps to Reproduce the Bug or Issue

  1. go to Lightdash login page
  2. Copy the email from this thread: https://lightdash.slack.com/archives/C071TU6FZ3P/p1715209151450089?thread_ts=1715205246.461809&cid=C071TU6FZ3P you can even replace some parts and still get the error.
  3. type any password (it doesn't matter if it is not valid )
  4. Get email is not valid error (doesn't do backend request)

version

No response

Cloud or self-hosting

None

@rephus rephus added the 🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience label May 10, 2024
@SandipGyawali
Copy link

@rephus i this it's character encoding issue or formatting differences.

can i give it a try to fix this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience
Projects
None yet
Development

No branches or pull requests

2 participants