Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference lines are broken on week-based axes #10027

Open
magnew opened this issue May 9, 2024 · 1 comment
Open

Reference lines are broken on week-based axes #10027

magnew opened this issue May 9, 2024 · 1 comment
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience

Comments

@magnew
Copy link
Contributor

magnew commented May 9, 2024

Description

Reference lines are broken on week-based axes

Steps to Reproduce the Bug or Issue

Create a chart with a WEEK data type on one axis. Try to add a reference line.

version

No response

Cloud or self-hosting

None

@magnew magnew added the 🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience label May 9, 2024
@magnew magnew self-assigned this May 9, 2024
@magnew magnew self-assigned this May 14, 2024
@magnew
Copy link
Contributor Author

magnew commented May 14, 2024

This is caused be the fact that we moved weeks to use a categorical axis. We suspected there would be some tradeoffs and this is the most painful tradeoff we've seen. Reference lines can't be added to any value on a categorical axis, then have to line up with a category. So you can have a reference line that corresponds with week-start, but not Wednesday, for example. A couple of options here:

  • Keep the limitation that lines can only be on weeks, but make it more clear
  • Use a numeric axis when there is a reference line is added. This will be a little weird with the labels changing.
  • Try using a separate axis for the reference lines and hide everything but the line. This might work, might not. And might be very hard to get right.
  • Go back to the drawing board with trying to customize numeric axes in such a way that we can get the labels we want and keep the lines.

@magnew magnew removed their assignment May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience
Projects
Status: 📝 To-Do
Development

No branches or pull requests

1 participant