Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all users to see underlying data with custom SQL dimensions #10023

Open
ZeRego opened this issue May 9, 2024 · 0 comments
Open

Allow all users to see underlying data with custom SQL dimensions #10023

ZeRego opened this issue May 9, 2024 · 0 comments
Assignees
Labels
✨ feature-request Request for a new feature or functionality

Comments

@ZeRego
Copy link
Contributor

ZeRego commented May 9, 2024

Description

Not developers/admins will get an error when seeing the underlying data of a saved chart that has custom SQL dimension.

This is because the metric query is generated in the FE and passed to the BE.
We need to change the API to build the metric query in the BE so the user can't tamper with the custom SQL.

"Explore from here" and "drill by" buttons should exclude custom SQL dimensions to avoid errors.

What problem does this solve?

Not developers/admins can see the underlying data of a saved chart that has custom SQL dimension.

@ZeRego ZeRego added the ✨ feature-request Request for a new feature or functionality label May 9, 2024
@ZeRego ZeRego self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature-request Request for a new feature or functionality
Projects
None yet
Development

No branches or pull requests

1 participant