feat: custom dimensions can reference dimensions #10041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlas
requested a deployment
to
feat/custom-sql-dimension-references - jaffle_db_pg_13 PR #10041
Render
Abandoned
owlas
temporarily deployed
to
feat/custom-sql-dimension-references - headless-browser PR #10041
Render
Destroyed
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
ZeRego
changed the title
owlas
temporarily deployed
to
feat/custom-sql-dimension-references - lightdash PR #10041
Render
Destroyed
almeidabbm
approved these changes
May 13, 2024
lightdash-bot
pushed a commit
that referenced
this pull request
May 13, 2024
# [0.1092.0](0.1091.0...0.1092.0) (2024-05-13) ### Features * custom dimensions can reference dimensions ([#10041](#10041)) ([9137595](9137595))
|
🎉 This PR is included in version 0.1092.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10022
Description:
What this PR includes:
SQL input should autocomplete dimensions references
generated SQL should use SQL from the referred dimension
generated SQL should join necessary tables based on referred dimensions
What this PR doesn't include:
reference other custom dimensions
Preview
Reviewer actions