Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference other dimensions inside custom dimensions #10022

Closed
ZeRego opened this issue May 9, 2024 · 1 comment · Fixed by #10041
Closed

Reference other dimensions inside custom dimensions #10022

ZeRego opened this issue May 9, 2024 · 1 comment · Fixed by #10041
Assignees
@ZeRego
Labels
✨ feature-request Request for a new feature or functionality released
Milestone
🛃 Custom dimensio...

Comments

@ZeRego
Copy link
Contributor

ZeRego commented May 9, 2024

Description

Requirements:

  • SQL input should autocomplete dimensions references
  • generated SQL should use SQL from the referred dimension
  • generated SQL should join necessary tables based on referred dimensions

What problem does this solve?

Consistency as I don't need to copy the dimension SQL.
Refer dimensions from other tables as auto joins tables correctly.
@ZeRego ZeRego added the ✨ feature-request Request for a new feature or functionality label May 9, 2024
@ZeRego ZeRego mentioned this issue May 9, 2024
Closed
7 tasks
@ZeRego ZeRego self-assigned this May 10, 2024
@ZeRego ZeRego mentioned this issue May 10, 2024
Merged
3 tasks
@lightdash-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 0.1092.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZeRego ZeRego

Labels
✨ feature-request Request for a new feature or functionality released
Projects
Selected for Development
Archived in project
Milestone
🛃 Custom dimensions created from cust...
Development

Successfully merging a pull request may close this issue.

feat: custom dimensions can reference dimensions lightdash/lightdash
2 participants
@ZeRego @lightdash-bot