Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix undefiled type table calculation on bignumber #10031

Merged
merged 1 commit into from May 13, 2024
Merged

fix: fix undefiled type table calculation on bignumber #10031

merged 1 commit into from May 13, 2024

Conversation

rephus
Copy link
Collaborator

@rephus rephus commented May 10, 2024

Closes: #10018

What was the issue:

new table calculations now have types, but existing table calculations has type as undefined. For undefined table calculations, we assume they are strings (for backwards compatibility) but this assumption is not correct on bignumber.

Description:

Screenshot from 2024-05-10 09-08-10

Before:

Screenshot from 2024-05-10 09-02-22

Screenshot from 2024-05-10 08-55-23

After:

Screenshot from 2024-05-10 08-58-51

Screenshot from 2024-05-10 09-02-31

For strings:

Screenshot from 2024-05-10 09-03-43

(new check type) For table calculation with string type:

Screenshot from 2024-05-10 09-05-20

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@owlas owlas requested a deployment to fix-table-calculation-bignumber - jaffle_db_pg_13 PR #10031 May 10, 2024 07:12 — with Render Abandoned
@rephus rephus requested a review from almeidabbm May 10, 2024 07:12
@owlas owlas temporarily deployed to fix-table-calculation-bignumber - headless-browser PR #10031 May 10, 2024 07:12 — with Render Destroyed
@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

✅ Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit c8d50c8
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/663dc8e82583bb000831c15b

@owlas owlas temporarily deployed to fix-table-calculation-bignumber - lightdash PR #10031 May 10, 2024 07:14 — with Render Destroyed
@rephus rephus merged commit e0be1df into main May 13, 2024
47 of 52 checks passed
@rephus rephus deleted the fix-table-calculation-bignumber branch May 13, 2024 06:38
lightdash-bot pushed a commit that referenced this pull request May 13, 2024
@semantic-release-bot
chore(release): 0.1090.7
6c519ce 
## [0.1090.7](0.1090.6...0.1090.7) (2024-05-13)

### Bug Fixes

* empty integrations redirection ([#10044](#10044)) ([1e19031](1e19031))
* fix undefiled type table calculation on bignumber ([#10031](#10031)) ([e0be1df](e0be1df))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1090.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidabbm almeidabbm almeidabbm approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Existing) big number comparisons on table calculation fields are broken
4 participants
@rephus @lightdash-bot @almeidabbm @owlas