Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply dashboard filters to underlying data query #10032

Merged
merged 1 commit into from May 13, 2024
Merged

fix: apply dashboard filters to underlying data query #10032

merged 1 commit into from May 13, 2024

Conversation

magnew
Copy link
Contributor

@magnew magnew commented May 10, 2024

Closes: #10006

Description:

Apply dashboard filters to view underlying query.

We were leaving out filters on fields that weren't part of the chart display.

To test:

  • Apply a new filter to a dashboard
  • View underlying data on a chart in the dashboard that is affected by the filter
  • Make sure the new filter is reflected in the underlying data query

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@magnew magnew requested a review from almeidabbm May 10, 2024 08:35
@magnew magnew linked an issue May 10, 2024 that may be closed by this pull request
dashboard filters aren't being applied to show underlying data #10006
Closed
@owlas owlas requested a deployment to 10006-dashboard-filters-arent-being-applied-to-show-underlying-data - jaffle_db_pg_13 PR #10032 May 10, 2024 08:35 — with Render Abandoned
@owlas owlas temporarily deployed to 10006-dashboard-filters-arent-being-applied-to-show-underlying-data - headless-browser PR #10032 May 10, 2024 08:35 — with Render Destroyed
@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

✅ Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit aed7b21
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/663ddc55fc1af50008dcc83f

@owlas owlas temporarily deployed to 10006-dashboard-filters-arent-being-applied-to-show-underlying-data - lightdash PR #10032 May 10, 2024 08:36 — with Render Destroyed
almeidabbm
almeidabbm approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@almeidabbm almeidabbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@magnew magnew merged commit c534ac5 into main May 13, 2024
48 of 52 checks passed
@magnew magnew deleted the 10006-dashboard-filters-arent-being-applied-to-show-underlying-data branch May 13, 2024 08:59
lightdash-bot pushed a commit that referenced this pull request May 13, 2024
@semantic-release-bot
chore(release): 0.1090.8
61ff43d 
## [0.1090.8](0.1090.7...0.1090.8) (2024-05-13)

### Bug Fixes

* apply dashboard filters to underlying data query ([#10032](#10032)) ([c534ac5](c534ac5))
* switch tab clears temp filters state ([#10025](#10025)) ([a1d3e1c](a1d3e1c))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1090.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidabbm almeidabbm almeidabbm approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dashboard filters aren't being applied to show underlying data
4 participants
@magnew @lightdash-bot @almeidabbm @owlas