Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@clayui/css): Utilities c-prefers-expanded-text shouldn't display… #5622

Closed
wants to merge 1 commit into from

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Jul 5, 2023

… text in a column

fixes #5620

@ethib137 c-prefers-expanded-text with tabs should look like:

tabs

The page editor tabs use the utility class flex-nowrap. It will overflow on the right, we need to remove it if we want the tabs to break to new line with long text.

@matuzalemsteles
Copy link
Member

In these cases instead of breaking the line maybe it would be better to keep everyone on the same lines but with scroll? this looks a lot better on a mobile UI especially when you can have multiple tabs.

@marcoscv-work
Copy link
Member

Hey gusy! I would say double scroll is not a good practice, there is not something in WCAG speaking directly about that, but Reflow speaks about two dimensions scrolling https://www.w3.org/WAI/WCAG21/Understanding/reflow.html

If we could predict this problem, probably we could change tabs by pills tabs, something like:
image

Or use lines to delimit the tabs:
image

This could work better, even if we need JS to know if we are showing the component in more than a line.

@matuzalemsteles
Copy link
Member

@marcoscv-work could we not consider this behavior similar to the behavior of a table with horizontal scrolling for smaller screens so as not to break the view?

@pat270
Copy link
Member Author

pat270 commented Feb 29, 2024

This has been here too long. I'm going to close for now.

@pat270 pat270 closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@clayui/css: c-prefers-expanded-text util breaks tab text
3 participants