Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LilaRouter's PathBindable[Color] chokes on /<gameid>/note, /<gameid>/mini, /<gameid>/edit #15272

Closed
schlawg opened this issue May 10, 2024 · 5 comments

Comments

@schlawg
Copy link
Collaborator

schlawg commented May 10, 2024

Not as ugly as actual IDs competing with static segments that look like IDs in a path, but it's close. Should be fun to fix these.

image

@ornicar
Copy link
Collaborator

ornicar commented May 11, 2024

513fb1f

@ornicar ornicar closed this as completed May 11, 2024
@alexkay
Copy link

alexkay commented May 11, 2024

Notes still don't work, when will the fix be deployed? I use notes to keep track of moves and ideas for correspondence games (they can span weeks). As it is, without seeing my notes correspondence games are unplayable 😢

@alexkay
Copy link

alexkay commented May 11, 2024

For example, GET https://lichess.org/e6ZpFLQv/note returns 404 - Invalid chess color, should be white or black.

@ornicar
Copy link
Collaborator

ornicar commented May 12, 2024

tomorrow

@alexkay
Copy link

alexkay commented May 13, 2024

Confirming it's fixed now, thank you! 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants