Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast FIDE player guessing + replacements: match characters ä, ö, ü, ß #15152

Open
AAArmstark opened this issue Apr 28, 2024 · 2 comments
Open

Broadcast FIDE player guessing + replacements: match characters ä, ö, ü, ß #15152

AAArmstark opened this issue Apr 28, 2024 · 2 comments
Labels
improvement Small incremental improvement to an existing feature

Comments

@AAArmstark
Copy link
Contributor

ö < - > oe
ä < - > ae
ü < - > ue
ß < - > ss

The characters on the left are very common in for example German names and included in broadcast sources like the German Bundesliga, but the FIDE player guessing won't work because FIDE always uses the characters on the right (Matthias Blübaum -> Matthias Bluebaum) and the best way to handle this currently is to add multiple entries for the same player in the broadcast player replacements to make one of the names match.
@kraktus kraktus added the improvement Small incremental improvement to an existing feature label Apr 29, 2024
tors42 added a commit to tors42/lichess-lila that referenced this issue May 5, 2024
@tors42
Consider umlaut forms when building tokenized map
dd6aba9 
Allows for writing broadcast player replacements using umlaut form (i.e
"Blübaum" instead of "Bluebaum") and have replacement happen even if the
name in the PGN is spelled "Bluebaum".

Previously each player replacement name was mapped into a single token
string which identifies the replacement info:
"Matthias Blübaum" -> Map("blubaum matthias" -> ReplacementInfo)

Now names with umlauts will make an additional mapping:
"Matthias Blübaum" -> Map("blubaum matthias"  -> ReplacementInfo,
                          "bluebaum matthias" -> ReplacementInfo)

Relates: lichess-org#15152
@tors42 tors42 mentioned this issue May 5, 2024
Merged
@kraktus
Copy link
Member

kraktus commented May 6, 2024

closed by #15235

@kraktus kraktus closed this as completed May 6, 2024
@tors42
Copy link
Contributor

tors42 commented May 6, 2024

#15235 only targeted half of this issue (the "+ replacements" part),
the "FIDE player guessing" part is remaining

@kraktus kraktus reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Small incremental improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tors42 @kraktus @AAArmstark