{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":36074217,"defaultBranch":"master","name":"libvirt","ownerLogin":"libvirt","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-05-22T13:40:12.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/12560713?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714641097.0","currentOid":""},"activityList":{"items":[{"before":"fa5459517848f333743c771e90eb01faeced3dae","after":"3146305fd3a610573963fe4858cc12ec1c4cf5c7","ref":"refs/heads/master","pushedAt":"2024-05-02T22:01:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"libxl: Fix domxml-to-native conversion\n\nSimilar to commit 57d084febe, another case of the libxl driver not\nadapting to modular daemons. When converting configuration that\ncontains a type='network' interface, the converter calls\nvirNetworkLookupByName, passing the hypervisor connection object\ninstead of a connection to virtnetworkd. E.g.\n\n> cat dom.xml\n...\n \n \n \n...\n> virsh net-info default\nName: default\nUUID: 25a5b089-1e71-4956-99aa-df2213bbb407\nActive: yes\nPersistent: no\nAutostart: no\nBridge: virbr0\n> virsh domxml-to-native xen-xl dom.xml\nerror: Network not found: default\n\nAcquire a connection to virtnetworkd and use it when calling\nvirNetwork* APIs.\n\nSigned-off-by: Jim Fehlig \nReviewed-by: Ján Tomko ","shortMessageHtmlLink":"libxl: Fix domxml-to-native conversion"}},{"before":"23c47944882bca4b0684ff9b4cf71f7e44235eba","after":"fa5459517848f333743c771e90eb01faeced3dae","ref":"refs/heads/master","pushedAt":"2024-05-02T18:00:11.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"cpu_map: Drop 'mpx' from x86 cpu models\n\nThe mpx feature was removed from the corresponding qemu cpu models.\nWith mpx in the libvirt cpu models, libvirt believes the feature\nto be implicitly enabled when creating qemu VMs, while in fact it is\ndisabled.\n\nThis became an issue when commit 94eacd5a5f introduced new vmx-*\nfeatures, of which some are dependent on mpx (see \"feature_dependencies\"\ntable in qemu target/i386/cpu.c), e.g. vmx-exit-clear-bndcfgs and\nvmx-entry-load-bndcfgs. These features cannot be enabled by qemu\nwithout also mpx being enabled, leading to the error message\n\n error: Failed to create domain from testdomain.xml\n error: operation failed: guest CPU doesn't match\n specification: missing features: mpx,vmx-exit-clear-bndcfgs,\n vmx-entry-load-bndcfgs\n\nwhen trying to create a VM with a \"host-model\" cpu on a host that\ndoes support mpx and the mentioned vmx-* features:\n\n \n ...\n \n ...\n \n\nResolve the issue by removing mpx from libvirt's cpu models as well.\n\nSigned-off-by: Tim Wiederhake \nReviewed-by: Ján Tomko ","shortMessageHtmlLink":"cpu_map: Drop 'mpx' from x86 cpu models"}},{"before":"8074d64dc2eca846d6a61efe1a9b7428a0ce1dd1","after":"23c47944882bca4b0684ff9b4cf71f7e44235eba","ref":"refs/heads/master","pushedAt":"2024-05-02T15:29:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"vmx: Check serialX.vspc before serialX.fileName\n\nWhen using vSPC (Virtual Serial Port Concentrator) in vSphere the actual\naddress for it is saved in serialX.vspc in which case the\nserialX.fileName is most probably something we can't get any useful\ninformation from and we also fail during the parsing rendering any\ndumpxml and similar tries unsuccessful.\n\nInstead of parsing the vspc URL with something along the lines of\n`virURIParse(vspc ? vspc : fileName)`, which could lead to us reporting\ninformation that is very prune to misuse (the vSPC seemingly has a\nprotocol on top of the telnet connection; redefining the domain would\nchange the behaviour; the URL might have a fragment we are not saving;\netc.) or adding more XML knobs to indicate vSPC usage (which we would\nnot be able to configure; we'd have to properly error out everywhere;\netc.) let's just report dummy serial port that leads to nowhere (i.e.\ntype=\"null\").\n\nResolves: https://issues.redhat.com/browse/RHEL-32182\nSigned-off-by: Martin Kletzander \nReviewed-by: Michal Privoznik ","shortMessageHtmlLink":"vmx: Check serialX.vspc before serialX.fileName"}},{"before":"a1a3da94f5ef087834afcdfe7c9db5b3a0b1ad82","after":"8074d64dc2eca846d6a61efe1a9b7428a0ce1dd1","ref":"refs/heads/master","pushedAt":"2024-05-02T13:46:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"rpc: ensure temporary GSource is removed from client event loop\n\nUsers are seeing periodic segfaults from libvirt client apps,\nespecially thread heavy ones like virt-manager. A typical\nstack trace would end up in the virNetClientIOEventFD method,\nwith illegal access to stale stack data. eg\n\n==238721==ERROR: AddressSanitizer: stack-use-after-return on address 0x75cd18709788 at pc 0x75cd3111f907 bp 0x75cd181ff550 sp 0x75cd181ff548\nWRITE of size 4 at 0x75cd18709788 thread T11\n #0 0x75cd3111f906 in virNetClientIOEventFD /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/rpc/virnetclient.c:1634:15\n #1 0x75cd3210d198 (/usr/lib/libglib-2.0.so.0+0x5a198) (BuildId: 0a2311dfbbc6c215dc36f4b6bdd2b4b6fbae55a2)\n #2 0x75cd3216c3be (/usr/lib/libglib-2.0.so.0+0xb93be) (BuildId: 0a2311dfbbc6c215dc36f4b6bdd2b4b6fbae55a2)\n #3 0x75cd3210ddc6 in g_main_loop_run (/usr/lib/libglib-2.0.so.0+0x5adc6) (BuildId: 0a2311dfbbc6c215dc36f4b6bdd2b4b6fbae55a2)\n #4 0x75cd3111a47c in virNetClientIOEventLoop /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/rpc/virnetclient.c:1722:9\n #5 0x75cd3111a47c in virNetClientIO /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/rpc/virnetclient.c:2002:10\n #6 0x75cd3111a47c in virNetClientSendInternal /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/rpc/virnetclient.c:2170:11\n #7 0x75cd311198a8 in virNetClientSendWithReply /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/rpc/virnetclient.c:2198:11\n #8 0x75cd31111653 in virNetClientProgramCall /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/rpc/virnetclientprogram.c:318:9\n #9 0x75cd31241c8f in callFull /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/remote/remote_driver.c:6054:10\n #10 0x75cd31241c8f in call /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/remote/remote_driver.c:6076:12\n #11 0x75cd31241c8f in remoteNetworkGetXMLDesc /usr/src/debug/libvirt/libvirt-10.2.0/build/src/remote/remote_client_bodies.h:5959:9\n #12 0x75cd31410ff7 in virNetworkGetXMLDesc /usr/src/debug/libvirt/libvirt-10.2.0/build/../src/libvirt-network.c:952:15\n\nThe root cause is a bad assumption in the virNetClientIOEventLoop\nmethod. This method is run by whichever thread currently owns the\nbuck, and is responsible for handling I/O. Inside a for(;;) loop,\nthis method creates a temporary GSource, adds it to the event loop\nand runs g_main_loop_run(). When I/O is ready, the GSource callback\n(virNetClientIOEventFD) will fire and call g_main_loop_quit(), and\nreturn G_SOURCE_REMOVE which results in the temporary GSource being\ndestroyed. A g_autoptr() will then remove the last reference.\n\nWhat was overlooked, is that a second thread can come along and\nwhile it can't enter virNetClientIOEventLoop, it will register an\nidle source that uses virNetClientIOWakeup to interrupt the\noriginal thread's 'g_main_loop_run' call. When this happens the\nvirNetClientIOEventFD callback never runs, and so the temporary\nGSource is not destroyed. The g_autoptr() will remove a reference,\nbut by virtue of still being attached to the event context, there\nis an extra reference held causing GSource to be leaked. The\nnext time 'g_main_loop_run' is called, the original GSource will\ntrigger its callback, and access data that was allocated on the\nstack by the previous thread, and likely SEGV.\n\nTo solve this, the thread calling 'g_main_loop_run' must call\ng_source_destroy, immediately upon return, to guarantee that\nthe temporary GSource is removed.\n\nCVE-2024-4418\nReviewed-by: Ján Tomko \nReported-by: Martin Shirokov \nTested-by: Martin Shirokov \nSigned-off-by: Daniel P. Berrangé ","shortMessageHtmlLink":"rpc: ensure temporary GSource is removed from client event loop"}},{"before":"d754500e5ff010681489a3715c149b14f1e9b0da","after":"a1a3da94f5ef087834afcdfe7c9db5b3a0b1ad82","ref":"refs/heads/master","pushedAt":"2024-05-02T13:39:32.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"qemu: Generate command line for sound devices with model 'virtio'\n\nAllow generation of command line for virtio-sound-pci and virtio-sound-device\ndevices along with additional virtio options.\n\nA new testcase is added to test virtio-sound-pci. The\narm-vexpressa9-virtio testcase is also extended to test virtio-sound-device.\n\nSigned-off-by: Rayhan Faizel \nReviewed-by: Ján Tomko ","shortMessageHtmlLink":"qemu: Generate command line for sound devices with model 'virtio'"}},{"before":"bc70aa1df33ce91820111058e22f00eeef13036b","after":"d754500e5ff010681489a3715c149b14f1e9b0da","ref":"refs/heads/master","pushedAt":"2024-05-02T12:53:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"ci: drop CentOS 8 Stream and refresh\n\nThis drops the CentOS 8 Stream distro target, since that is going EOL\nat the end of May, at which point it will cease to be installable\ndue to package repos being archived.\n\nReviewed-by: Michal Privoznik \nSigned-off-by: Daniel P. Berrangé ","shortMessageHtmlLink":"ci: drop CentOS 8 Stream and refresh"}},{"before":"c95cc67efb21518a3a4d3aecc16ab51e38f5d4a1","after":"bc70aa1df33ce91820111058e22f00eeef13036b","ref":"refs/heads/master","pushedAt":"2024-05-02T12:39:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"scripts/meson-dist.py: Get builddir from env too\n\nWhen meson runs a dist script it sets both MESON_BUILD_ROOT and\nMESON_DIST_ROOT envvars [1]. But for some reason, we took the\nformer as an argument and obtained the latter via env. Well,\nobtain both via env.\n\n1: https://mesonbuild.com/Reference-manual_builtin_meson.html#mesonadd_dist_script\nSigned-off-by: Michal Privoznik \nReviewed-by: Ján Tomko ","shortMessageHtmlLink":"scripts/meson-dist.py: Get builddir from env too"}},{"before":"8c80acdec049e49f100ff46948b516bb621fbbb7","after":"c95cc67efb21518a3a4d3aecc16ab51e38f5d4a1","ref":"refs/heads/master","pushedAt":"2024-05-02T11:18:43.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"qemu: format machine virt ras feature and test it\n\nResolves: https://issues.redhat.com/browse/RHEL-7489\nSigned-off-by: Kristina Hanicova \nReviewed-by: Michal Privoznik \nReviewed-by: Ján Tomko ","shortMessageHtmlLink":"qemu: format machine virt ras feature and test it"}},{"before":"ad3796c5cac7661e55ba9a33dfd3a249547b8329","after":"8c80acdec049e49f100ff46948b516bb621fbbb7","ref":"refs/heads/master","pushedAt":"2024-05-02T09:11:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"Post-release version bump to 10.4.0\n\nSigned-off-by: Jiri Denemark ","shortMessageHtmlLink":"Post-release version bump to 10.4.0"}},{"before":"311284b3d8a0f2b3a5c46fc4aaf1ddb6dfb6f105","after":"ad3796c5cac7661e55ba9a33dfd3a249547b8329","ref":"refs/heads/master","pushedAt":"2024-05-02T08:31:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"NEWS: Document my contributions for upcoming release\n\nSigned-off-by: Michal Privoznik \nReviewed-by: Peter Krempa \nReviewed-by: Jiri Denemark ","shortMessageHtmlLink":"NEWS: Document my contributions for upcoming release"}},{"before":"310bf2e2ac9ccc7cd1e05897e285a041c5bb20b1","after":"311284b3d8a0f2b3a5c46fc4aaf1ddb6dfb6f105","ref":"refs/heads/master","pushedAt":"2024-05-02T07:42:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"Translated using Weblate (Swedish)\n\nCurrently translated at 71.0% (7403 of 10423 strings)\n\nTranslation: libvirt/libvirt\nTranslate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/sv/\n\nCo-authored-by: Göran Uddeborg \nSigned-off-by: Göran Uddeborg ","shortMessageHtmlLink":"Translated using Weblate (Swedish)"}},{"before":"63f00d09e3bf7442cddf3657b51b0bc645f8c434","after":"310bf2e2ac9ccc7cd1e05897e285a041c5bb20b1","ref":"refs/heads/master","pushedAt":"2024-05-02T06:13:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"NEWS: Document TLS migration bug, usb-net support and two fixes\n\nSigned-off-by: Peter Krempa \nReviewed-by: Jiri Denemark ","shortMessageHtmlLink":"NEWS: Document TLS migration bug, usb-net support and two fixes"}},{"before":"51589f154d9ca1ea76db42784bbfee9752c5a72b","after":"63f00d09e3bf7442cddf3657b51b0bc645f8c434","ref":"refs/heads/master","pushedAt":"2024-04-30T07:16:50.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"Translated using Weblate (Korean)\n\nCurrently translated at 100.0% (10423 of 10423 strings)\n\nTranslation: libvirt/libvirt\nTranslate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/ko/\n\nSigned-off-by: 김인수 ","shortMessageHtmlLink":"Translated using Weblate (Korean)"}},{"before":"966b394216111162cc45bc01e6e2f79b113785ca","after":"51589f154d9ca1ea76db42784bbfee9752c5a72b","ref":"refs/heads/master","pushedAt":"2024-04-26T08:22:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"po: Refresh potfile for v10.3.0\n\nSigned-off-by: Jiri Denemark ","shortMessageHtmlLink":"po: Refresh potfile for v10.3.0"}},{"before":"5540c3d2415c194b206f8946cf74b13648163332","after":"966b394216111162cc45bc01e6e2f79b113785ca","ref":"refs/heads/master","pushedAt":"2024-04-26T08:00:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"Translated using Weblate (Swedish)\n\nCurrently translated at 70.3% (7345 of 10438 strings)\n\nTranslation: libvirt/libvirt\nTranslate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/sv/\n\nCo-authored-by: Göran Uddeborg \nSigned-off-by: Göran Uddeborg ","shortMessageHtmlLink":"Translated using Weblate (Swedish)"}},{"before":"ac9c3c0b2ce4ce8b2501ec3f2e27fe2bf4dd61f4","after":"5540c3d2415c194b206f8946cf74b13648163332","ref":"refs/heads/master","pushedAt":"2024-04-25T12:22:29.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"vsh: Refactor logic in vshCommandParse\n\nRefactor the existing logic using two nested loops with a jump into the\nmiddle of both with 3 separate places fetching next token to a single\nloop using a state machine with one centralized place to fetch next\ntokens and add explanation comments.\n\nSigned-off-by: Peter Krempa \nReviewed-by: Michal Privoznik ","shortMessageHtmlLink":"vsh: Refactor logic in vshCommandParse"}},{"before":"948d496d2546807e8c3af634fa982615b2a3153b","after":"ac9c3c0b2ce4ce8b2501ec3f2e27fe2bf4dd61f4","ref":"refs/heads/master","pushedAt":"2024-04-25T07:45:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"virnetdevbandwidth.c: Put a limit to \"quantum\"\n\nThe \"quantum\" attribute of HTB is documented as:\n\n Number of bytes to serve from this class before the scheduler\n moves to the next class.\n\nSince v1.3.2-rc1~225 we compute what we think is the appropriate\nvalue and pass it on the TC command line. But kernel and\nsubsequently TC use uint32_t to store this value. If we compute\nvalue outside of this type then TC fails and prints usage which\nwe then interpret as an error message. Needlessly long error\nmessage. While there's not much we can do about the latter, we\ncan put a cap on the value and stop tickling this behavior of TC.\n\nFixes: 065054daa71f645fc83aff0271f194d326208616\nResolves: https://issues.redhat.com/browse/RHEL-34112\nSigned-off-by: Michal Privoznik \nReviewed-by: Peter Krempa ","shortMessageHtmlLink":"virnetdevbandwidth.c: Put a limit to \"quantum\""}},{"before":"7a5baa450d25c77dc7fb595d143e2dd01ab21c86","after":"948d496d2546807e8c3af634fa982615b2a3153b","ref":"refs/heads/master","pushedAt":"2024-04-24T13:40:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"test: nodedev: fill active_config at driver startup time\n\nCommit v10.0.0-265-ge67bca23e4 added a `active_config` and\n`defined_config` to nodedev mdev internal XML handling.\n`defined_config` can be filled at XML parse time, but `active_config`\nmust be filled in by nodedev driver. This wasn't implemented for the\ntest driver however, which caused virt-manager test suite regressions.\n\nWorking example:\n\n```\n$ virsh --connect test:///home/crobinso/src/virt-manager/tests/data/testdriver/testdriver.xml nodedev-dumpxml mdev_8e37ee90_2b51_45e3_9b25_bf8283c03110\n\n mdev_8e37ee90_2b51_45e3_9b25_bf8283c03110\n /sys/devices/css0/0.0.0023/8e37ee90-2b51-45e3-9b25-bf8283c03110\n css_0_0_0023\n \n \n \n \n\n```\n\nBroken example:\n\n```\n$ virsh --connect test:///home/crobinso/src/virt-manager/tests/data/testdriver/testdriver.xml nodedev-dumpxml mdev_8e37ee90_2b51_45e3_9b25_bf8283c03110\n\n mdev_8e37ee90_2b51_45e3_9b25_bf8283c03110\n /sys/devices/css0/0.0.0023/8e37ee90-2b51-45e3-9b25-bf8283c03110\n css_0_0_0023\n \n \n \n\n```\n\nThere's already code that does what we want in the test suite.\nMove it to a shared function, and call it in test driver when\ncreating a nodedev from driver startup XML.\n\nReviewed-by: Boris Fiuczynski \nSigned-off-by: Cole Robinson ","shortMessageHtmlLink":"test: nodedev: fill active_config at driver startup time"}},{"before":"83c5072e2ddd25082a3e4bfe1ec40079adc58506","after":"7a5baa450d25c77dc7fb595d143e2dd01ab21c86","ref":"refs/heads/master","pushedAt":"2024-04-24T12:44:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"Translated using Weblate (Swedish)\n\nCurrently translated at 70.1% (7325 of 10438 strings)\n\nTranslation: libvirt/libvirt\nTranslate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/sv/\n\nCo-authored-by: Göran Uddeborg \nSigned-off-by: Göran Uddeborg ","shortMessageHtmlLink":"Translated using Weblate (Swedish)"}},{"before":"c09f84cb9c2d5841ecb00a665dd3fb316cba7fe6","after":"83c5072e2ddd25082a3e4bfe1ec40079adc58506","ref":"refs/heads/master","pushedAt":"2024-04-24T12:32:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"virDomainDeviceIsUSB: Handle all USB devices and simplify the code\n\nRework 'virDomainUSBDeviceDefForeach' to use virDomainDeviceInfoIterate\ninstead of open-coding all iterators. To achieve this\n'virDomainDeviceIsUSB' needs to be fixed as it didn't properly handle\n'sound', 'fs', 'chr', 'ccid', and 'net' usb devices.\n\nSigned-off-by: Peter Krempa \nReviewed-by: Jonathon Jongsma ","shortMessageHtmlLink":"virDomainDeviceIsUSB: Handle all USB devices and simplify the code"}},{"before":"9544b67c6b8417089eda6b55a7abe8acc1f82ed5","after":"c09f84cb9c2d5841ecb00a665dd3fb316cba7fe6","ref":"refs/heads/master","pushedAt":"2024-04-24T12:22:47.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"qemucapabilitiestest: Update qemu capability dump for qemu-9.0 release\n\nqemu-9.0 was released so update the capability dump to the final\nversion.\n\nNotable changes:\n - the 'vdpa' simulator support was reverted for now\n\nSigned-off-by: Peter Krempa \nReviewed-by: Pavel Hrdina ","shortMessageHtmlLink":"qemucapabilitiestest: Update qemu capability dump for qemu-9.0 release"}},{"before":"4690058b6d3dab672bd18ff69c83392245253024","after":"9544b67c6b8417089eda6b55a7abe8acc1f82ed5","ref":"refs/heads/master","pushedAt":"2024-04-24T11:19:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"virnetdevopenvswitch: Create OVS ports as transient\n\nSince OVS keeps desired state in a DB, upon sudden crash of the\nhost we may leave a port behind. There's no problem on VM\nshutdown or NIC hotunplug as we call corresponding del-port\nfunction (virNetDevOpenvswitchRemovePort()). But if the host\nsuddenly crashes we won't ever do that. What happens next, is\nwhen OVS starts it finds desired state in its DB and creates a\nstale port.\n\nOVS added support for transient ports in v2.5.0 (Feb 2016) and\nsince its v2.9.0 it even installs a systemd service\n(ovs-delete-transient-ports) that automatically deletes transient\nports on system startup. If we mark a port as transient then OVS\nwon't restore its state on restart after crash.\n\nThis change may render \"--may-exist\" argument redundant, but I'm\nnot sure about all the implications if it was removed. Let's keep\nit for now.\n\nResolves: https://gitlab.com/libvirt/libvirt/-/issues/615\nSigned-off-by: Michal Privoznik \nReviewed-by: Laine Stump ","shortMessageHtmlLink":"virnetdevopenvswitch: Create OVS ports as transient"}},{"before":"595b95cdde39a78528e584fdfd71a1d562ba9e45","after":"4690058b6d3dab672bd18ff69c83392245253024","ref":"refs/heads/master","pushedAt":"2024-04-24T08:33:05.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"qemu_validate: Reject virtiofs with bootindex on s390x with CCW\n\nThe CCW variant of the 'vhost-user-fs' device in qemu doesn't\ndeliberately support the 'bootindex' attribute as the machine is unable\nto boot from such device.\n\nReject '\nReviewed-by: Boris Fiuczynski ","shortMessageHtmlLink":"qemu_validate: Reject virtiofs with bootindex on s390x with CCW"}},{"before":"c38720b337f74337ec94c0fe2e97a7c2c57188ae","after":"595b95cdde39a78528e584fdfd71a1d562ba9e45","ref":"refs/heads/master","pushedAt":"2024-04-23T08:19:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"Translated using Weblate (Swedish)\n\nCurrently translated at 69.9% (7305 of 10438 strings)\n\nTranslation: libvirt/libvirt\nTranslate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/sv/\n\nTranslated using Weblate (Swedish)\n\nCurrently translated at 69.6% (7265 of 10438 strings)\n\nTranslation: libvirt/libvirt\nTranslate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/sv/\n\nCo-authored-by: Göran Uddeborg \nSigned-off-by: Göran Uddeborg ","shortMessageHtmlLink":"Translated using Weblate (Swedish)"}},{"before":"753064963ce35434c91e3b6ae6bfcd1754197db2","after":"c38720b337f74337ec94c0fe2e97a7c2c57188ae","ref":"refs/heads/master","pushedAt":"2024-04-19T12:29:51.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"qemu_command: Generate mem-reserve for controllers\n\nPretty straightforward. Just put mem-reserve attribute whenever\nit's set. Previous commit ensures it's set only for valid\ncontroller models.\n\nResolves: https://issues.redhat.com/browse/RHEL-7461\nSigned-off-by: Michal Privoznik \nReviewed-by: Andrea Bolognani ","shortMessageHtmlLink":"qemu_command: Generate mem-reserve for controllers"}},{"before":"e314a8fe91ed7472a24f44f9d5e88e4abb52f96a","after":"753064963ce35434c91e3b6ae6bfcd1754197db2","ref":"refs/heads/master","pushedAt":"2024-04-18T12:59:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"libvirt_nss: Fix ERROR() macro\n\nThe purpose of ERROR() macro in our NSS module is to print error\nmessage provided as arguments followed by error string\ncorresponding to errno. Historically, we've used strerror_r() for\nthat (please note, we want our NSS module to be free of libvirt\ninternal functions, or glib even - hence, g_strerror() is off the\ntable).\n\nNow strerror_r() is documented as:\n\n Returns ... a pointer to a string that the function stores in\n buf, or a pointer to some (immutable) static string (in which\n case buf is unused).\n\nTherefore, we can't rely the string being stored in the buf and\nreally need to store the retval and print that instead.\n\nWhile touching this area, decrease the ebuf size, since its\ncurrent size (1KiB) is triggering our stack limit (2KiB) in some\ncases.\n\nSigned-off-by: Michal Privoznik \nReviewed-by: Peter Krempa ","shortMessageHtmlLink":"libvirt_nss: Fix ERROR() macro"}},{"before":"6eb4c6ad209559e54908b9553b5e8d48be56bebf","after":"e314a8fe91ed7472a24f44f9d5e88e4abb52f96a","ref":"refs/heads/master","pushedAt":"2024-04-18T10:30:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"Translated using Weblate (Swedish)\n\nCurrently translated at 69.4% (7245 of 10438 strings)\n\nTranslation: libvirt/libvirt\nTranslate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/sv/\n\nCo-authored-by: Göran Uddeborg \nSigned-off-by: Göran Uddeborg ","shortMessageHtmlLink":"Translated using Weblate (Swedish)"}},{"before":"601aaf60cd153c8431d4a3c12790377f45d43c71","after":"6eb4c6ad209559e54908b9553b5e8d48be56bebf","ref":"refs/heads/master","pushedAt":"2024-04-17T15:38:09.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"qemu: Change return type of qemuDomainFixupCPUs to void\n\nThe function never fails.\n\nSigned-off-by: Jiri Denemark \nReviewed-by: Peter Krempa ","shortMessageHtmlLink":"qemu: Change return type of qemuDomainFixupCPUs to void"}},{"before":"e5b7f1e266103b06cf00361c9f483e080e3543ad","after":"601aaf60cd153c8431d4a3c12790377f45d43c71","ref":"refs/heads/master","pushedAt":"2024-04-17T15:01:10.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"test: Implement virNodeDeviceIsPersistent\n\nReviewed-by: Michal Privoznik \nReviewed-by: Boris Fiuczynski \nSigned-off-by: Cole Robinson ","shortMessageHtmlLink":"test: Implement virNodeDeviceIsPersistent"}},{"before":"ded74b33699bdaf67bc57e2ad311f94fd96c7f6e","after":"e5b7f1e266103b06cf00361c9f483e080e3543ad","ref":"refs/heads/master","pushedAt":"2024-04-17T12:16:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"libvirtmirror","name":null,"path":"/libvirtmirror","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12560784?s=80&v=4"},"commit":{"message":"network: ensure nparams is non-NULL and non-negative\n\nThe typed parameter array length must be non-NULL and either 0, or a\npositive number.\n\nReviewed-by: Ján Tomko \nSigned-off-by: Daniel P. Berrangé ","shortMessageHtmlLink":"network: ensure nparams is non-NULL and non-negative"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQD8t5AA","startCursor":null,"endCursor":null}},"title":"Activity · libvirt/libvirt"}